[PR #1152] [MERGED] Fix encoding for mapping with local members #919

New Issue

adam · 2025-12-30T01:27:45+01:00

adam commented

2025-12-30 01:27:45 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1152
Author: @bioball
Created: 7/25/2025
Status: ✅ Merged
Merged: 7/28/2025
Merged by: @bioball

Base: main ← Head: fix-mapping-encoding

📝 Commits (1)

82afea7 Fix encoding for mapping with local members

📊 Changes

5 files changed (+54 additions, -32 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/runtime/VmMapping.java (+21 -15)
📝 pkl-core/src/main/java/org/pkl/core/stdlib/base/MappingNodes.java (+1 -15)
📝 pkl-server/src/main/kotlin/org/pkl/server/BinaryEvaluator.kt (+1 -1)
📝 pkl-server/src/test/files/SnippetTests/input/map.pkl (+6 -0)
📝 pkl-server/src/test/files/SnippetTests/output/map.yaml (+25 -1)

📄 Description

Fixes an issue where local members are included in the mapping entry count.

Also: avoid re-computing Mapping.length

Closes #1151

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1152 **Author:** [@bioball](https://github.com/bioball) **Created:** 7/25/2025 **Status:** ✅ Merged **Merged:** 7/28/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix-mapping-encoding` --- ### 📝 Commits (1) - [`82afea7`](https://github.com/apple/pkl/commit/82afea77aa510fee60c56dcbd7e1122feaca6d9f) Fix encoding for mapping with local members ### 📊 Changes **5 files changed** (+54 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmMapping.java` (+21 -15) 📝 `pkl-core/src/main/java/org/pkl/core/stdlib/base/MappingNodes.java` (+1 -15) 📝 `pkl-server/src/main/kotlin/org/pkl/server/BinaryEvaluator.kt` (+1 -1) 📝 `pkl-server/src/test/files/SnippetTests/input/map.pkl` (+6 -0) 📝 `pkl-server/src/test/files/SnippetTests/output/map.yaml` (+25 -1) </details> ### 📄 Description Fixes an issue where local members are included in the mapping entry count. Also: avoid re-computing `Mapping.length` Closes #1151 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:45 +01:00

adam closed this issue

2025-12-30 01:27:45 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#919