[PR #1141] [MERGED] Fix: use http.rewrites to configure the evaluator in message passing API #913

New Issue

adam · 2025-12-30T01:27:43+01:00

adam commented

2025-12-30 01:27:43 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1141
Author: @bioball
Created: 7/23/2025
Status: ✅ Merged
Merged: 7/24/2025
Merged by: @bioball

Base: main ← Head: server-mode-http-rewrites-fix

📝 Commits (1)

e062810 Fix: use http.rewrites to configure the evaluator in message passing API

📊 Changes

6 files changed (+117 additions, -48 deletions)

View changed files

📝 pkl-server/src/main/kotlin/org/pkl/server/Server.kt (+47 -42)
📝 pkl-server/src/main/kotlin/org/pkl/server/ServerMessagePackDecoder.kt (+2 -2)
📝 pkl-server/src/main/kotlin/org/pkl/server/ServerMessagePackEncoder.kt (+2 -2)
📝 pkl-server/src/main/kotlin/org/pkl/server/ServerMessages.kt (+1 -1)
📝 pkl-server/src/test/kotlin/org/pkl/server/AbstractServerTest.kt (+64 -0)
📝 pkl-server/src/test/kotlin/org/pkl/server/ServerMessagePackCodecTest.kt (+1 -1)

📄 Description

This is a bugfix, where the rewrites option is currently ignored.

Also: return any illegal argument errors from creating the evaluator as an error in the CreateEvaluatorResponse

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1141 **Author:** [@bioball](https://github.com/bioball) **Created:** 7/23/2025 **Status:** ✅ Merged **Merged:** 7/24/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `server-mode-http-rewrites-fix` --- ### 📝 Commits (1) - [`e062810`](https://github.com/apple/pkl/commit/e062810a5062e5ae256f1a8020b3be715efd33dc) Fix: use http.rewrites to configure the evaluator in message passing API ### 📊 Changes **6 files changed** (+117 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `pkl-server/src/main/kotlin/org/pkl/server/Server.kt` (+47 -42) 📝 `pkl-server/src/main/kotlin/org/pkl/server/ServerMessagePackDecoder.kt` (+2 -2) 📝 `pkl-server/src/main/kotlin/org/pkl/server/ServerMessagePackEncoder.kt` (+2 -2) 📝 `pkl-server/src/main/kotlin/org/pkl/server/ServerMessages.kt` (+1 -1) 📝 `pkl-server/src/test/kotlin/org/pkl/server/AbstractServerTest.kt` (+64 -0) 📝 `pkl-server/src/test/kotlin/org/pkl/server/ServerMessagePackCodecTest.kt` (+1 -1) </details> ### 📄 Description This is a bugfix, where the `rewrites` option is currently ignored. Also: return any illegal argument errors from creating the evaluator as an error in the CreateEvaluatorResponse --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:43 +01:00

adam closed this issue

2025-12-30 01:27:43 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#913