[PR #1143] [MERGED] Defer noproxy to settings.pkl or PklProject if not set explicitly #912

New Issue

adam · 2025-12-30T01:27:43+01:00

adam commented

2025-12-30 01:27:43 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1143
Author: @bioball
Created: 7/23/2025
Status: ✅ Merged
Merged: 7/23/2025
Merged by: @bioball

Base: main ← Head: fix-http-noproxy

📝 Commits (1)

cf9d54a Defer noproxy to settings.pkl or PklProject if not set explicitly

📊 Changes

3 files changed (+95 additions, -1 deletions)

View changed files

📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt (+86 -0)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliMainTest.kt (+8 -0)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt (+1 -1)

📄 Description

Fixes an issue where http.noProxy settings are ignored.

Closes #1142

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1143 **Author:** [@bioball](https://github.com/bioball) **Created:** 7/23/2025 **Status:** ✅ Merged **Merged:** 7/23/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix-http-noproxy` --- ### 📝 Commits (1) - [`cf9d54a`](https://github.com/apple/pkl/commit/cf9d54a22b7bd352b7753856629299097d511bea) Defer noproxy to settings.pkl or PklProject if not set explicitly ### 📊 Changes **3 files changed** (+95 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt` (+86 -0) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliMainTest.kt` (+8 -0) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt` (+1 -1) </details> ### 📄 Description Fixes an issue where `http.noProxy` settings are ignored. Closes #1142 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:43 +01:00

adam closed this issue

2025-12-30 01:27:43 +01:00

adam referenced this issue

2025-12-30 01:28:26 +01:00

[PR #1354] Add `Reference<T>` #1039

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#912