[PR #1133] [MERGED] Polish http rewrites #904

New Issue

adam · 2025-12-30T01:27:40+01:00

adam commented

2025-12-30 01:27:40 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1133
Author: @bioball
Created: 7/22/2025
Status: ✅ Merged
Merged: 7/23/2025
Merged by: @bioball

Base: main ← Head: polish-http-rewrites

📝 Commits (3)

f20433f Polish rewrite docs
86689a3 Add documentation comments, add missing evaluator options
54fe190 Fix pklExecutorClassLoader1

📊 Changes

7 files changed (+225 additions, -54 deletions)

View changed files

📝 pkl-config-java/src/main/java/org/pkl/config/java/ConfigEvaluatorBuilder.java (+27 -5)
📝 pkl-core/src/main/java/org/pkl/core/http/HttpClient.java (+27 -0)
📝 pkl-core/src/main/java/org/pkl/core/service/ExecutorSpiImpl.java (+18 -36)
📝 pkl-executor/src/main/java/org/pkl/executor/ExecutorOptions.java (+54 -2)
➕ pkl-executor/src/main/java/org/pkl/executor/spi/v1/ExecutorSpiOptions3.java (+63 -0)
📝 pkl-executor/src/test/kotlin/org/pkl/executor/EmbeddedExecutorTest.kt (+34 -9)
📝 stdlib/EvaluatorSettings.pkl (+2 -2)

📄 Description

Add ability to set HTTP builder in ConfigEvaluatorBuilder
Add ability to set rewrites in executor API
Polish documentation

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1133 **Author:** [@bioball](https://github.com/bioball) **Created:** 7/22/2025 **Status:** ✅ Merged **Merged:** 7/23/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `polish-http-rewrites` --- ### 📝 Commits (3) - [`f20433f`](https://github.com/apple/pkl/commit/f20433f3945927f712ad0f00172931d0d8a0ead9) Polish rewrite docs - [`86689a3`](https://github.com/apple/pkl/commit/86689a3668068b3c38caf6bddaf3481c79947786) Add documentation comments, add missing evaluator options - [`54fe190`](https://github.com/apple/pkl/commit/54fe1904b4470f1d7a76e058d827ff8226df8af9) Fix pklExecutorClassLoader1 ### 📊 Changes **7 files changed** (+225 additions, -54 deletions) <details> <summary>View changed files</summary> 📝 `pkl-config-java/src/main/java/org/pkl/config/java/ConfigEvaluatorBuilder.java` (+27 -5) 📝 `pkl-core/src/main/java/org/pkl/core/http/HttpClient.java` (+27 -0) 📝 `pkl-core/src/main/java/org/pkl/core/service/ExecutorSpiImpl.java` (+18 -36) 📝 `pkl-executor/src/main/java/org/pkl/executor/ExecutorOptions.java` (+54 -2) ➕ `pkl-executor/src/main/java/org/pkl/executor/spi/v1/ExecutorSpiOptions3.java` (+63 -0) 📝 `pkl-executor/src/test/kotlin/org/pkl/executor/EmbeddedExecutorTest.kt` (+34 -9) 📝 `stdlib/EvaluatorSettings.pkl` (+2 -2) </details> ### 📄 Description * Add ability to set HTTP builder in ConfigEvaluatorBuilder * Add ability to set rewrites in executor API * Polish documentation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:40 +01:00

adam closed this issue

2025-12-30 01:27:40 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#904