starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 14:20:35 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #1131] [MERGED] Run graal_attach_thread ahead of all calls #903

New Issue
Closed
opened 2025-12-30 01:27:40 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:27:40 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1131
Author: @KushalP
Created: 7/21/2025
Status: ✅ Merged
Merged: 7/21/2025
Merged by: @KushalP

Base: c-library ← Head: c-library-attach-thread

📝 Commits (2)

  • 56bd06b Rename isolatethread to graal_isolatethread
  • 6857c2a Run graal_attach_thread ahead of all calls

📊 Changes

1 file changed (+41 additions, -11 deletions)

View changed files

📝 libpkl/src/main/c/pkl.c (+41 -11)

📄 Description

This is to deal with the case when using a language like Golang, where
a Goroutine is managed by the runtime, and can be moved to an
arbitrary system thread behind the scenes.

This PR is the sibling PR mentioned in https://github.com/apple/pkl-go/pull/149

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1131 **Author:** [@KushalP](https://github.com/KushalP) **Created:** 7/21/2025 **Status:** ✅ Merged **Merged:** 7/21/2025 **Merged by:** [@KushalP](https://github.com/KushalP) **Base:** `c-library` ← **Head:** `c-library-attach-thread` --- ### 📝 Commits (2) - [`56bd06b`](https://github.com/apple/pkl/commit/56bd06bd02672e71c6ce0c92d378151aab1a1217) Rename `isolatethread` to `graal_isolatethread` - [`6857c2a`](https://github.com/apple/pkl/commit/6857c2ae22212b071ff7744224b14dabb6d3379c) Run `graal_attach_thread` ahead of all calls ### 📊 Changes **1 file changed** (+41 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `libpkl/src/main/c/pkl.c` (+41 -11) </details> ### 📄 Description This is to deal with the case when using a language like Golang, where a Goroutine is managed by the runtime, and can be moved to an arbitrary system thread behind the scenes. This PR is the sibling PR mentioned in https://github.com/apple/pkl-go/pull/149 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:27:40 +01:00
adam closed this issue 2025-12-30 01:27:40 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#903
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?