[PR #1112] [MERGED] Fix crash due to parse error in module header #896

New Issue

adam · 2025-12-30T01:27:37+01:00

adam commented

2025-12-30 01:27:37 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1112
Author: @HT154
Created: 7/1/2025
Status: ✅ Merged
Merged: 7/1/2025
Merged by: @stackoverflow

Base: main ← Head: fix-invalid-module-decl-crash

📝 Commits (1)

b01db79 Fix crash due to parse error in module header

📊 Changes

4 files changed (+10 additions, -1 deletions)

View changed files

➕ pkl-core/src/test/files/LanguageSnippetTests/input/modules/invalidModule1.pkl (+1 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/modules/invalidModule1.err (+6 -0)
📝 pkl-parser/src/main/java/org/pkl/parser/syntax/Module.java (+2 -1)
📝 pkl-parser/src/test/kotlin/org/pkl/parser/ParserComparisonTest.kt (+1 -0)

📄 Description

Fixes #1111

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1112 **Author:** [@HT154](https://github.com/HT154) **Created:** 7/1/2025 **Status:** ✅ Merged **Merged:** 7/1/2025 **Merged by:** [@stackoverflow](https://github.com/stackoverflow) **Base:** `main` ← **Head:** `fix-invalid-module-decl-crash` --- ### 📝 Commits (1) - [`b01db79`](https://github.com/apple/pkl/commit/b01db79f931e6be384575fd54ad472bdfc6ae16a) Fix crash due to parse error in module header ### 📊 Changes **4 files changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/modules/invalidModule1.pkl` (+1 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/modules/invalidModule1.err` (+6 -0) 📝 `pkl-parser/src/main/java/org/pkl/parser/syntax/Module.java` (+2 -1) 📝 `pkl-parser/src/test/kotlin/org/pkl/parser/ParserComparisonTest.kt` (+1 -0) </details> ### 📄 Description Fixes #1111 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:37 +01:00

adam closed this issue

2025-12-30 01:27:37 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#896