[PR #1115] [MERGED] Add Kotlin support for "addGeneratedAnnotation" flag #895

New Issue

adam · 2025-12-30T01:27:37+01:00

adam commented

2025-12-30 01:27:37 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1115
Author: @bioball
Created: 7/8/2025
Status: ✅ Merged
Merged: 7/8/2025
Merged by: @bioball

Base: main ← Head: generated-polish

📝 Commits (2)

7dc0aaf Add Kotlin support for "addGeneratedAnnotation" flag
50ede7d Address PR comments

📊 Changes

14 files changed (+76 additions, -15 deletions)

View changed files

📝 docs/modules/java-binding/partials/cli-codegen-options.adoc (+7 -0)
📝 docs/modules/pkl-gradle/partials/gradle-codegen-properties.adoc (+8 -0)
📝 pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/CliJavaCodeGeneratorOptions.kt (+3 -3)
📝 pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/JavaCodeGenerator.kt (+3 -3)
📝 pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/Main.kt (+3 -3)
📝 pkl-codegen-java/src/test/kotlin/org/pkl/codegen/java/JavaCodeGeneratorTest.kt (+1 -1)
📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorOptions.kt (+4 -0)
📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/KotlinCodeGenerator.kt (+9 -0)
📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/Main.kt (+7 -0)
📝 pkl-codegen-kotlin/src/test/kotlin/org/pkl/codegen/kotlin/KotlinCodeGeneratorTest.kt (+24 -0)
📝 pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java (+3 -2)
📝 pkl-gradle/src/main/java/org/pkl/gradle/task/CodeGenTask.java (+1 -1)
📝 pkl-gradle/src/main/java/org/pkl/gradle/task/JavaCodeGenTask.java (+1 -1)
📝 pkl-gradle/src/main/java/org/pkl/gradle/task/KotlinCodeGenTask.java (+2 -1)

📄 Description

This adds logic so that the Kotlin code generator also supports the "addGeneratedAnnotation" flag.

Also:

Add Antora documentation
Adjust names (generated-annotation -> add-generated-annotation)
Adjust doc comments

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1115 **Author:** [@bioball](https://github.com/bioball) **Created:** 7/8/2025 **Status:** ✅ Merged **Merged:** 7/8/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `generated-polish` --- ### 📝 Commits (2) - [`7dc0aaf`](https://github.com/apple/pkl/commit/7dc0aaf983e91e3dbc0da94c3fd9f4b701258c01) Add Kotlin support for "addGeneratedAnnotation" flag - [`50ede7d`](https://github.com/apple/pkl/commit/50ede7d15a15dc0f45e0400fff7ab9fe5fcd2205) Address PR comments ### 📊 Changes **14 files changed** (+76 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/java-binding/partials/cli-codegen-options.adoc` (+7 -0) 📝 `docs/modules/pkl-gradle/partials/gradle-codegen-properties.adoc` (+8 -0) 📝 `pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/CliJavaCodeGeneratorOptions.kt` (+3 -3) 📝 `pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/JavaCodeGenerator.kt` (+3 -3) 📝 `pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/Main.kt` (+3 -3) 📝 `pkl-codegen-java/src/test/kotlin/org/pkl/codegen/java/JavaCodeGeneratorTest.kt` (+1 -1) 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorOptions.kt` (+4 -0) 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/KotlinCodeGenerator.kt` (+9 -0) 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/Main.kt` (+7 -0) 📝 `pkl-codegen-kotlin/src/test/kotlin/org/pkl/codegen/kotlin/KotlinCodeGeneratorTest.kt` (+24 -0) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java` (+3 -2) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/task/CodeGenTask.java` (+1 -1) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/task/JavaCodeGenTask.java` (+1 -1) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/task/KotlinCodeGenTask.java` (+2 -1) </details> ### 📄 Description This adds logic so that the Kotlin code generator also supports the "addGeneratedAnnotation" flag. Also: * Add Antora documentation * Adjust names (generated-annotation -> add-generated-annotation) * Adjust doc comments --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:37 +01:00

adam closed this issue

2025-12-30 01:27:37 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#895