starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-09-03 16:37:17 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #1110] [MERGED] Don't show 100% when number of failures is rounded up #894

New Issue
Closed
opened 2025-12-30 01:27:37 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:27:37 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1110
Author: @gordonbondon
Created: 6/25/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @stackoverflow

Base: main ← Head: tests-percentage

📝 Commits (3)

  • 66a9d75 Don't show 100% when number of failures is rounded up
  • b87762c Switch to using math rounding
  • f070b91 Fix other failed examples

📊 Changes

3 files changed (+89 additions, -11 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/stdlib/test/report/SimpleReport.java (+12 -8)
➕ pkl-core/src/test/kotlin/org/pkl/core/stdlib/SimpleReportTest.kt (+74 -0)
📝 pkl-gradle/src/test/kotlin/org/pkl/gradle/TestsTest.kt (+3 -3)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1110 **Author:** [@gordonbondon](https://github.com/gordonbondon) **Created:** 6/25/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@stackoverflow](https://github.com/stackoverflow) **Base:** `main` ← **Head:** `tests-percentage` --- ### 📝 Commits (3) - [`66a9d75`](https://github.com/apple/pkl/commit/66a9d7598609394b7612ee136752d1aad9cee8d8) Don't show 100% when number of failures is rounded up - [`b87762c`](https://github.com/apple/pkl/commit/b87762c8b4b49be29b9ea15d807a31d6a76edb56) Switch to using math rounding - [`f070b91`](https://github.com/apple/pkl/commit/f070b9111d788cde8e38fac724aa0ef25b562906) Fix other failed examples ### 📊 Changes **3 files changed** (+89 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/stdlib/test/report/SimpleReport.java` (+12 -8) ➕ `pkl-core/src/test/kotlin/org/pkl/core/stdlib/SimpleReportTest.kt` (+74 -0) 📝 `pkl-gradle/src/test/kotlin/org/pkl/gradle/TestsTest.kt` (+3 -3) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:27:37 +01:00
adam closed this issue 2025-12-30 01:27:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#894