[PR #1114] [MERGED] Remove ANTLR from the repo #893

New Issue

adam · 2025-12-30T01:27:36+01:00

adam commented

2025-12-30 01:27:36 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1114
Author: @stackoverflow
Created: 7/7/2025
Status: ✅ Merged
Merged: 7/8/2025
Merged by: @stackoverflow

Base: main ← Head: remove-antlr

📝 Commits (1)

b2f9488 Remove ANTLR from the repo

📊 Changes

15 files changed (+0 additions, -2459 deletions)

View changed files

📝 .gitignore (+0 -4)
📝 DEVELOPMENT.adoc (+0 -2)
📝 build.gradle.kts (+0 -4)
📝 buildSrc/src/main/kotlin/pklFatJar.gradle.kts (+0 -3)
📝 docs/docs.gradle.kts (+0 -1)
📝 docs/gradle.lockfile (+0 -1)
📝 gradle/libs.versions.toml (+0 -3)
📝 pkl-parser/gradle.lockfile (+0 -6)
📝 pkl-parser/pkl-parser.gradle.kts (+0 -47)
➖ pkl-parser/src/test/antlr/PklLexer.g4 (+0 -387)
➖ pkl-parser/src/test/antlr/PklParser.g4 (+0 -254)
➖ pkl-parser/src/test/kotlin/org/pkl/parser/ANTLRSexpRenderer.kt (+0 -1067)
➖ pkl-parser/src/test/kotlin/org/pkl/parser/ParserComparisonTest.kt (+0 -104)
➖ pkl-parser/src/test/kotlin/org/pkl/parser/ParserComparisonTestInterface.kt (+0 -112)
➖ pkl-parser/src/test/kotlin/org/pkl/parser/SpanComparison.kt (+0 -464)

📄 Description

The new parser is already battle tested enough that we don't need to compare it to the older one.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1114 **Author:** [@stackoverflow](https://github.com/stackoverflow) **Created:** 7/7/2025 **Status:** ✅ Merged **Merged:** 7/8/2025 **Merged by:** [@stackoverflow](https://github.com/stackoverflow) **Base:** `main` ← **Head:** `remove-antlr` --- ### 📝 Commits (1) - [`b2f9488`](https://github.com/apple/pkl/commit/b2f9488d21fc950c2209e1ea7cf0dc5be247b8dc) Remove ANTLR from the repo ### 📊 Changes **15 files changed** (+0 additions, -2459 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+0 -4) 📝 `DEVELOPMENT.adoc` (+0 -2) 📝 `build.gradle.kts` (+0 -4) 📝 `buildSrc/src/main/kotlin/pklFatJar.gradle.kts` (+0 -3) 📝 `docs/docs.gradle.kts` (+0 -1) 📝 `docs/gradle.lockfile` (+0 -1) 📝 `gradle/libs.versions.toml` (+0 -3) 📝 `pkl-parser/gradle.lockfile` (+0 -6) 📝 `pkl-parser/pkl-parser.gradle.kts` (+0 -47) ➖ `pkl-parser/src/test/antlr/PklLexer.g4` (+0 -387) ➖ `pkl-parser/src/test/antlr/PklParser.g4` (+0 -254) ➖ `pkl-parser/src/test/kotlin/org/pkl/parser/ANTLRSexpRenderer.kt` (+0 -1067) ➖ `pkl-parser/src/test/kotlin/org/pkl/parser/ParserComparisonTest.kt` (+0 -104) ➖ `pkl-parser/src/test/kotlin/org/pkl/parser/ParserComparisonTestInterface.kt` (+0 -112) ➖ `pkl-parser/src/test/kotlin/org/pkl/parser/SpanComparison.kt` (+0 -464) </details> ### 📄 Description The new parser is already battle tested enough that we don't need to compare it to the older one. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:36 +01:00

adam closed this issue

2025-12-30 01:27:37 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#893