[PR #1099] [MERGED] Fix native build #888

New Issue

adam · 2025-12-30T01:27:35+01:00

adam commented

2025-12-30 01:27:35 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1099
Author: @bioball
Created: 6/16/2025
Status: ✅ Merged
Merged: 6/17/2025
Merged by: @bioball

Base: main ← Head: fix-native-build

📝 Commits (3)

fe920a9 Add truffle boundaries
064b896 Fix snippet output tests
c70c360 Make java LanguageSnippetTests eval outpu.bytes

📊 Changes

216 files changed (+870 additions, -5 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/ast/expression/literal/BytesLiteralNode.java (+1 -0)
📝 pkl-core/src/main/java/org/pkl/core/stdlib/base/BytesNodes.java (+9 -3)
📝 pkl-core/src/main/java/org/pkl/core/util/ByteArrayUtils.java (+7 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/jsonRenderer8.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/jsonnetRenderer7.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/pListRenderer7.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/pcfRenderer8.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/propertiesRenderer10.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/propertiesRenderer11.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/xmlRenderer8.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/yamlRenderer7.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/basic/exceptions.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/classes/class3.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/classes/constraints5.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/classes/inheritanceError1.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/classes/invalidInstantiation1.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/classes/invalidInstantiation2.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/classes/unionTypesErrorAlias.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/classes/unionTypesErrorDifferent1.err (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/classes/unionTypesErrorDifferent2.err (+4 -0)

...and 80 more files

📄 Description

Add missing truffle boundaries
Make Java snippet tests eval output.bytes, just like the CLI does
Overwrite language snippet output files

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1099 **Author:** [@bioball](https://github.com/bioball) **Created:** 6/16/2025 **Status:** ✅ Merged **Merged:** 6/17/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix-native-build` --- ### 📝 Commits (3) - [`fe920a9`](https://github.com/apple/pkl/commit/fe920a969e366c426bb61dfeafed2cd3b0a53904) Add truffle boundaries - [`064b896`](https://github.com/apple/pkl/commit/064b896d82dc698e08766cb65ebb4a1739946bcc) Fix snippet output tests - [`c70c360`](https://github.com/apple/pkl/commit/c70c360a8703f1272a83f4c3401ea95d8447dff5) Make java LanguageSnippetTests eval outpu.bytes ### 📊 Changes **216 files changed** (+870 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/literal/BytesLiteralNode.java` (+1 -0) 📝 `pkl-core/src/main/java/org/pkl/core/stdlib/base/BytesNodes.java` (+9 -3) 📝 `pkl-core/src/main/java/org/pkl/core/util/ByteArrayUtils.java` (+7 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/jsonRenderer8.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/jsonnetRenderer7.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/pListRenderer7.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/pcfRenderer8.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/propertiesRenderer10.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/propertiesRenderer11.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/xmlRenderer8.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/yamlRenderer7.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/basic/exceptions.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/classes/class3.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/classes/constraints5.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/classes/inheritanceError1.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/classes/invalidInstantiation1.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/classes/invalidInstantiation2.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/classes/unionTypesErrorAlias.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/classes/unionTypesErrorDifferent1.err` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/classes/unionTypesErrorDifferent2.err` (+4 -0) _...and 80 more files_ </details> ### 📄 Description * Add missing truffle boundaries * Make Java snippet tests eval `output.bytes`, just like the CLI does * Overwrite language snippet output files --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:35 +01:00

adam closed this issue

2025-12-30 01:27:35 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#888