[PR #1094] [MERGED] Add ResourceReaders#fromServiceProviders to preconfigured evaluator #883

New Issue

adam · 2025-12-30T01:27:33+01:00

adam commented

2025-12-30 01:27:33 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1094
Author: @bioball
Created: 6/6/2025
Status: ✅ Merged
Merged: 6/7/2025
Merged by: @bioball

Base: main ← Head: preconfigured-evaluator-resource-reader-spi

📝 Commits (1)

ce7de95 Add ResourceReaders#fromServiceProviders to preconfigured evaluator

📊 Changes

2 files changed (+11 additions, -2 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/EvaluatorBuilder.java (+3 -1)
📝 pkl-core/src/test/kotlin/org/pkl/core/EvaluatorBuilderTest.kt (+8 -1)

📄 Description

The preconfigured evaluator currently adds module key factories from service providers, but not resource readers.

This means that users of pkl-spring, for example, cannot add custom resource readers.
This is also inconsistent (in the preconfigured evaluator, import can use custom schemes, but not read).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1094 **Author:** [@bioball](https://github.com/bioball) **Created:** 6/6/2025 **Status:** ✅ Merged **Merged:** 6/7/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `preconfigured-evaluator-resource-reader-spi` --- ### 📝 Commits (1) - [`ce7de95`](https://github.com/apple/pkl/commit/ce7de95d2c770fccd33f30f7614dec0304ab35f5) Add ResourceReaders#fromServiceProviders to preconfigured evaluator ### 📊 Changes **2 files changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/EvaluatorBuilder.java` (+3 -1) 📝 `pkl-core/src/test/kotlin/org/pkl/core/EvaluatorBuilderTest.kt` (+8 -1) </details> ### 📄 Description The preconfigured evaluator currently adds module key factories from service providers, but not resource readers. This means that users of pkl-spring, for example, cannot add custom resource readers. This is also inconsistent (in the preconfigured evaluator, `import` can use custom schemes, but not `read`). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:33 +01:00

adam closed this issue

2025-12-30 01:27:33 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#883