[PR #1084] [MERGED] Make libpkl tests use AbstractServerTest #880

New Issue

adam · 2025-12-30T01:27:29+01:00

adam commented

2025-12-30 01:27:29 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1084
Author: @bioball
Created: 5/30/2025
Status: ✅ Merged
Merged: 6/2/2025
Merged by: @bioball

Base: c-library ← Head: libpkl-tests

📝 Commits (1)

59f53bc Make libpkl tests use AbstractServerTest

📊 Changes

19 files changed (+196 additions, -1115 deletions)

View changed files

📝 libpkl/src/main/c/pkl.h (+4 -4)
➖ libpkl/src/nativeTest/kotlin/org/pkl/libpkl/JNATestClient.kt (+0 -112)
📝 libpkl/src/nativeTest/kotlin/org/pkl/libpkl/LibPklJNA.kt (+2 -2)
➕ libpkl/src/nativeTest/kotlin/org/pkl/libpkl/LibPklMessageTransport.kt (+59 -0)
➕ libpkl/src/nativeTest/kotlin/org/pkl/libpkl/LibPklTest.kt (+46 -0)
➖ libpkl/src/nativeTest/kotlin/org/pkl/libpkl/MessagePackDebugRenderer.kt (+0 -107)
➖ libpkl/src/nativeTest/kotlin/org/pkl/libpkl/NativeTest.kt (+0 -873)
📝 pkl-commons-test/gradle.lockfile (+9 -0)
📝 pkl-commons-test/pkl-commons-test.gradle.kts (+3 -0)
📝 pkl-commons-test/src/main/kotlin/org/pkl/commons/test/MessagePackDebugRenderer.kt (+6 -3)
📝 pkl-commons-test/src/main/kotlin/org/pkl/commons/test/server/AbstractServerTest.kt (+39 -7)
📝 pkl-commons-test/src/main/kotlin/org/pkl/commons/test/server/TestTransport.kt (+2 -2)
📝 pkl-commons-test/src/main/resources/org/pkl/commons/test/server/resource1.jar (+0 -0)
📝 pkl-gradle/gradle.lockfile (+9 -0)
📝 pkl-parser/gradle.lockfile (+9 -0)
📝 pkl-server/src/test/kotlin/org/pkl/server/BinaryEvaluatorSnippetTests.kt (+2 -4)
📝 pkl-server/src/test/kotlin/org/pkl/server/BinaryEvaluatorTest.kt (+2 -1)
📝 pkl-server/src/test/kotlin/org/pkl/server/JvmServerTest.kt (+2 -0)
📝 pkl-server/src/test/kotlin/org/pkl/server/NativeServerTest.kt (+2 -0)

📄 Description

Move AbstractServerTest and its dependencies into pkl-commons-test
Make LibPklTest implement AbstractServerTest
Rename "NativeTest" -> "LibPklTest"
Rename "LibPklLibrary" -> "LibPklJNA"

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1084 **Author:** [@bioball](https://github.com/bioball) **Created:** 5/30/2025 **Status:** ✅ Merged **Merged:** 6/2/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `c-library` ← **Head:** `libpkl-tests` --- ### 📝 Commits (1) - [`59f53bc`](https://github.com/apple/pkl/commit/59f53bc51a51bb65164f65f4f5d1f302fcacd7f8) Make libpkl tests use AbstractServerTest ### 📊 Changes **19 files changed** (+196 additions, -1115 deletions) <details> <summary>View changed files</summary> 📝 `libpkl/src/main/c/pkl.h` (+4 -4) ➖ `libpkl/src/nativeTest/kotlin/org/pkl/libpkl/JNATestClient.kt` (+0 -112) 📝 `libpkl/src/nativeTest/kotlin/org/pkl/libpkl/LibPklJNA.kt` (+2 -2) ➕ `libpkl/src/nativeTest/kotlin/org/pkl/libpkl/LibPklMessageTransport.kt` (+59 -0) ➕ `libpkl/src/nativeTest/kotlin/org/pkl/libpkl/LibPklTest.kt` (+46 -0) ➖ `libpkl/src/nativeTest/kotlin/org/pkl/libpkl/MessagePackDebugRenderer.kt` (+0 -107) ➖ `libpkl/src/nativeTest/kotlin/org/pkl/libpkl/NativeTest.kt` (+0 -873) 📝 `pkl-commons-test/gradle.lockfile` (+9 -0) 📝 `pkl-commons-test/pkl-commons-test.gradle.kts` (+3 -0) 📝 `pkl-commons-test/src/main/kotlin/org/pkl/commons/test/MessagePackDebugRenderer.kt` (+6 -3) 📝 `pkl-commons-test/src/main/kotlin/org/pkl/commons/test/server/AbstractServerTest.kt` (+39 -7) 📝 `pkl-commons-test/src/main/kotlin/org/pkl/commons/test/server/TestTransport.kt` (+2 -2) 📝 `pkl-commons-test/src/main/resources/org/pkl/commons/test/server/resource1.jar` (+0 -0) 📝 `pkl-gradle/gradle.lockfile` (+9 -0) 📝 `pkl-parser/gradle.lockfile` (+9 -0) 📝 `pkl-server/src/test/kotlin/org/pkl/server/BinaryEvaluatorSnippetTests.kt` (+2 -4) 📝 `pkl-server/src/test/kotlin/org/pkl/server/BinaryEvaluatorTest.kt` (+2 -1) 📝 `pkl-server/src/test/kotlin/org/pkl/server/JvmServerTest.kt` (+2 -0) 📝 `pkl-server/src/test/kotlin/org/pkl/server/NativeServerTest.kt` (+2 -0) </details> ### 📄 Description * Move AbstractServerTest and its dependencies into pkl-commons-test * Make LibPklTest implement AbstractServerTest * Rename "NativeTest" -> "LibPklTest" * Rename "LibPklLibrary" -> "LibPklJNA" --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:29 +01:00

adam closed this issue

2025-12-30 01:27:31 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#880