starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 23:23:37 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #1078] [MERGED] Fix doc dependency link #879

New Issue
Closed
opened 2025-12-30 01:27:28 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:27:28 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1078
Author: @stackoverflow
Created: 5/26/2025
Status: ✅ Merged
Merged: 5/28/2025
Merged by: @stackoverflow

Base: main ← Head: fix-doc-dependency-link

📝 Commits (4)

📊 Changes

13 files changed (+44 additions, -24 deletions)

View changed files

📝 pkl-commons-test/src/main/files/packages/birds@0.5.0/birds@0.5.0.json (+1 -1)
📝 pkl-commons-test/src/main/files/packages/fruit@1.0.5/fruit@1.0.5.json (+0 -1)
📝 pkl-commons-test/src/main/kotlin/org/pkl/commons/test/PackageServer.kt (+2 -2)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/packages/packages1.pkl (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/packages/packages2.pkl (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/projects/project4/PklProject.deps.json (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/packages/packages2.pcf (+2 -2)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/DocPackageInfo.kt (+7 -0)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/DocScope.kt (+7 -2)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/PageGenerator.kt (+18 -9)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/index.html (+1 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/birds/0.5.0/Bird/index.html (+1 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/birds/0.5.0/index.html (+2 -2)

📄 Description

Package dependencies have wrong links sometimes due to how the URL is built.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1078 **Author:** [@stackoverflow](https://github.com/stackoverflow) **Created:** 5/26/2025 **Status:** ✅ Merged **Merged:** 5/28/2025 **Merged by:** [@stackoverflow](https://github.com/stackoverflow) **Base:** `main` ← **Head:** `fix-doc-dependency-link` --- ### 📝 Commits (4) - [`8660ffd`](https://github.com/apple/pkl/commit/8660ffd6446f01516c6d784cb141ffc3c11cc2ee) Fix doc dependency link - [`e5b418f`](https://github.com/apple/pkl/commit/e5b418f300d61832b0f0c6ec6c2f438d28386e5c) Add host to link - [`36a0f81`](https://github.com/apple/pkl/commit/36a0f81df1fd3038b5a0d6a055a309ef1cba0b3c) Encode dependency path - [`4bf7b09`](https://github.com/apple/pkl/commit/4bf7b09bfccb62889e7c658012459a8c5abbd526) Fix review remark ### 📊 Changes **13 files changed** (+44 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `pkl-commons-test/src/main/files/packages/birds@0.5.0/birds@0.5.0.json` (+1 -1) 📝 `pkl-commons-test/src/main/files/packages/fruit@1.0.5/fruit@1.0.5.json` (+0 -1) 📝 `pkl-commons-test/src/main/kotlin/org/pkl/commons/test/PackageServer.kt` (+2 -2) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/packages/packages1.pkl` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/packages/packages2.pkl` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/projects/project4/PklProject.deps.json` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/packages/packages2.pcf` (+2 -2) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/DocPackageInfo.kt` (+7 -0) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/DocScope.kt` (+7 -2) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/PageGenerator.kt` (+18 -9) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/com.package1/1.2.3/index.html` (+1 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/birds/0.5.0/Bird/index.html` (+1 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/localhost(3a)0/birds/0.5.0/index.html` (+2 -2) </details> ### 📄 Description Package dependencies have wrong links sometimes due to how the URL is built. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:27:28 +01:00
adam closed this issue 2025-12-30 01:27:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#879
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?