[PR #1056] [MERGED] Aggregate junit report into one file #869

New Issue

adam · 2025-12-30T01:27:25+01:00

adam commented

2025-12-30 01:27:25 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1056
Author: @gordonbondon
Created: 4/29/2025
Status: ✅ Merged
Merged: 6/7/2025
Merged by: @bioball

Base: main ← Head: junit-aggregate

📝 Commits (3)

d942993 Aggregate junit report into one file
1d2cffa Formatting
a71e3a1 Combine into one class

📊 Changes

11 files changed (+354 additions, -19 deletions)

View changed files

📝 docs/modules/pkl-cli/pages/index.adoc (+43 -1)
📝 docs/modules/pkl-gradle/pages/index.adoc (+20 -4)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliTestRunner.kt (+15 -3)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliTestRunnerTest.kt (+168 -0)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliTestOptions.kt (+7 -2)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/TestOptions.kt (+20 -1)
📝 pkl-core/src/main/java/org/pkl/core/stdlib/test/report/JUnitReport.java (+37 -1)
📝 pkl-core/src/main/java/org/pkl/core/stdlib/test/report/SimpleReport.java (+2 -1)
📝 pkl-core/src/main/java/org/pkl/core/stdlib/test/report/TestReport.java (+11 -2)
📝 pkl-gradle/src/main/java/org/pkl/gradle/task/ProjectPackageTask.java (+16 -2)
📝 pkl-gradle/src/main/java/org/pkl/gradle/task/TestTask.java (+15 -2)

📄 Description

Some systems require junit report to be in a single file. For example bazel https://bazel.build/reference/test-encyclopedia needs single file to be available in XML_OUTPUT_FILE path.

To avoid implementing junit aggregation in pkl wrappers in different places this PR instead adds a --junit-aggregate-reports flag to return all junit reports as a single file.

Additional flag --junit-aggregate-suite-name is added to allow overriding global test suite name from default pkl-tests

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1056 **Author:** [@gordonbondon](https://github.com/gordonbondon) **Created:** 4/29/2025 **Status:** ✅ Merged **Merged:** 6/7/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `junit-aggregate` --- ### 📝 Commits (3) - [`d942993`](https://github.com/apple/pkl/commit/d942993208e84d5e8f74938592d0a87affe2bd9e) Aggregate junit report into one file - [`1d2cffa`](https://github.com/apple/pkl/commit/1d2cffa08b20b6fa4884dd938de77931130090e8) Formatting - [`a71e3a1`](https://github.com/apple/pkl/commit/a71e3a1ba139864f352dec2a50515f0c1e9a53f7) Combine into one class ### 📊 Changes **11 files changed** (+354 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/pkl-cli/pages/index.adoc` (+43 -1) 📝 `docs/modules/pkl-gradle/pages/index.adoc` (+20 -4) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliTestRunner.kt` (+15 -3) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliTestRunnerTest.kt` (+168 -0) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliTestOptions.kt` (+7 -2) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/TestOptions.kt` (+20 -1) 📝 `pkl-core/src/main/java/org/pkl/core/stdlib/test/report/JUnitReport.java` (+37 -1) 📝 `pkl-core/src/main/java/org/pkl/core/stdlib/test/report/SimpleReport.java` (+2 -1) 📝 `pkl-core/src/main/java/org/pkl/core/stdlib/test/report/TestReport.java` (+11 -2) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/task/ProjectPackageTask.java` (+16 -2) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/task/TestTask.java` (+15 -2) </details> ### 📄 Description Some systems require junit report to be in a single file. For example `bazel` https://bazel.build/reference/test-encyclopedia needs single file to be available in `XML_OUTPUT_FILE` path. To avoid implementing junit aggregation in pkl wrappers in different places this PR instead adds a `--junit-aggregate-reports` flag to return all junit reports as a single file. Additional flag `--junit-aggregate-suite-name` is added to allow overriding global test suite name from default `pkl-tests` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:25 +01:00

adam closed this issue

2025-12-30 01:27:25 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#869