starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 14:20:35 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #1062] [MERGED] Add support for HTTP rewrites #868

New Issue
Closed
opened 2025-12-30 01:27:25 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:27:25 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1062
Author: @bioball
Created: 5/7/2025
Status: ✅ Merged
Merged: 7/17/2025
Merged by: @bioball

Base: main ← Head: http-rewrites

📝 Commits (8)

📊 Changes

27 files changed (+606 additions, -46 deletions)

View changed files

📝 docs/modules/language-reference/pages/index.adoc (+27 -1)
📝 docs/modules/pkl-cli/partials/cli-common-options.adoc (+11 -0)
📝 docs/modules/pkl-gradle/partials/gradle-common-properties.adoc (+11 -0)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliMainTest.kt (+30 -0)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliBaseOptions.kt (+4 -1)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliCommand.kt (+14 -5)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt (+34 -0)
📝 pkl-core/src/main/java/org/pkl/core/EvaluatorBuilder.java (+14 -0)
📝 pkl-core/src/main/java/org/pkl/core/evaluatorSettings/PklEvaluatorSettings.java (+21 -3)
📝 pkl-core/src/main/java/org/pkl/core/http/HttpClient.java (+6 -1)
📝 pkl-core/src/main/java/org/pkl/core/http/HttpClientBuilder.java (+25 -2)
📝 pkl-core/src/main/java/org/pkl/core/http/RequestRewritingClient.java (+116 -6)
📝 pkl-core/src/main/java/org/pkl/core/messaging/AbstractMessagePackEncoder.java (+8 -1)
📝 pkl-core/src/main/java/org/pkl/core/util/IoUtils.java (+13 -0)
➖ pkl-core/src/test/files/LanguageSnippetTests/input/errors/analyzeInvalidHttpModule.pkl (+0 -3)
➖ pkl-core/src/test/files/LanguageSnippetTests/output/errors/analyzeInvalidHttpModule.err (+0 -14)
📝 pkl-core/src/test/kotlin/org/pkl/core/http/RequestRewritingClientTest.kt (+181 -3)
📝 pkl-core/src/test/kotlin/org/pkl/core/settings/PklSettingsTest.kt (+9 -2)
📝 pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java (+1 -0)
📝 pkl-gradle/src/main/java/org/pkl/gradle/spec/BasePklSpec.java (+3 -1)

...and 7 more files

📄 Description

Follows the design of https://github.com/apple/pkl-evolution/pull/17

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1062 **Author:** [@bioball](https://github.com/bioball) **Created:** 5/7/2025 **Status:** ✅ Merged **Merged:** 7/17/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `http-rewrites` --- ### 📝 Commits (8) - [`ba52a93`](https://github.com/apple/pkl/commit/ba52a93063d3315ced75b8f3e1bea2a9a5302cc4) Add support for HTTP rewrites - [`ecc7047`](https://github.com/apple/pkl/commit/ecc7047b3d247afd1dda3e2f5b5684d2e05fc7a5) WIP - [`1c917ef`](https://github.com/apple/pkl/commit/1c917ef42e19d1bbd270a966df473879207479af) Run format, sort rewrites - [`7e3fe02`](https://github.com/apple/pkl/commit/7e3fe0211ee05a353e5bbe9c1df2d701e5b2350a) Add docs, add fixes - [`692c035`](https://github.com/apple/pkl/commit/692c035932d4868f1610378c34569dde1f51a156) Polish - [`9a8d8a2`](https://github.com/apple/pkl/commit/9a8d8a2f0104ae4bc0669cf234416b03db271b3c) fixes - [`82922aa`](https://github.com/apple/pkl/commit/82922aad1e7bf0115c43736c1666132d21b39be2) Adjust review feedback - [`5de00e0`](https://github.com/apple/pkl/commit/5de00e02449d4b6074886d59e539a42aad2c94a8) Polish docs ### 📊 Changes **27 files changed** (+606 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `docs/modules/language-reference/pages/index.adoc` (+27 -1) 📝 `docs/modules/pkl-cli/partials/cli-common-options.adoc` (+11 -0) 📝 `docs/modules/pkl-gradle/partials/gradle-common-properties.adoc` (+11 -0) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliMainTest.kt` (+30 -0) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliBaseOptions.kt` (+4 -1) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliCommand.kt` (+14 -5) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt` (+34 -0) 📝 `pkl-core/src/main/java/org/pkl/core/EvaluatorBuilder.java` (+14 -0) 📝 `pkl-core/src/main/java/org/pkl/core/evaluatorSettings/PklEvaluatorSettings.java` (+21 -3) 📝 `pkl-core/src/main/java/org/pkl/core/http/HttpClient.java` (+6 -1) 📝 `pkl-core/src/main/java/org/pkl/core/http/HttpClientBuilder.java` (+25 -2) 📝 `pkl-core/src/main/java/org/pkl/core/http/RequestRewritingClient.java` (+116 -6) 📝 `pkl-core/src/main/java/org/pkl/core/messaging/AbstractMessagePackEncoder.java` (+8 -1) 📝 `pkl-core/src/main/java/org/pkl/core/util/IoUtils.java` (+13 -0) ➖ `pkl-core/src/test/files/LanguageSnippetTests/input/errors/analyzeInvalidHttpModule.pkl` (+0 -3) ➖ `pkl-core/src/test/files/LanguageSnippetTests/output/errors/analyzeInvalidHttpModule.err` (+0 -14) 📝 `pkl-core/src/test/kotlin/org/pkl/core/http/RequestRewritingClientTest.kt` (+181 -3) 📝 `pkl-core/src/test/kotlin/org/pkl/core/settings/PklSettingsTest.kt` (+9 -2) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java` (+1 -0) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/spec/BasePklSpec.java` (+3 -1) _...and 7 more files_ </details> ### 📄 Description Follows the design of https://github.com/apple/pkl-evolution/pull/17 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:27:25 +01:00
adam closed this issue 2025-12-30 01:27:25 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#868
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?