[PR #1038] [MERGED] Do not crash, but suggest '--multiple-file-output-path' when specifying a directory as output file #863

New Issue

adam · 2025-12-30T01:27:17+01:00

adam commented

2025-12-30 01:27:17 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1038
Author: @JeroenSoeters
Created: 4/8/2025
Status: ✅ Merged
Merged: 4/8/2025
Merged by: @bioball

Base: main ← Head: suggest-multiple-file-output-path

📝 Commits (2)

e418f5b Do not crash, but suggest '--multiple-file-output-path' when specifying a directory as output file
ac6f3cd Add test

📊 Changes

2 files changed (+40 additions, -0 deletions)

View changed files

📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt (+7 -0)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt (+33 -0)

📄 Description

This PR fixes https://github.com/apple/pkl/issues/989

When specifying a directory instead of a file for the output, pkl won't crash anymore, but instead output an error message, suggesting --multiple-file-output-path.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1038 **Author:** [@JeroenSoeters](https://github.com/JeroenSoeters) **Created:** 4/8/2025 **Status:** ✅ Merged **Merged:** 4/8/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `suggest-multiple-file-output-path` --- ### 📝 Commits (2) - [`e418f5b`](https://github.com/apple/pkl/commit/e418f5ba0b1d05db4f0275b1e31da4aed5dc413c) Do not crash, but suggest '--multiple-file-output-path' when specifying a directory as output file - [`ac6f3cd`](https://github.com/apple/pkl/commit/ac6f3cd4188c684d3729b57297717abac3aa80d1) Add test ### 📊 Changes **2 files changed** (+40 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt` (+7 -0) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/CliEvaluatorTest.kt` (+33 -0) </details> ### 📄 Description This PR fixes https://github.com/apple/pkl/issues/989 When specifying a directory instead of a file for the output, `pkl` won't crash anymore, but instead output an error message, suggesting `--multiple-file-output-path`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:17 +01:00

adam closed this issue

2025-12-30 01:27:18 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#863