starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 23:23:37 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #1028] [MERGED] Fix incorrect substring #860

New Issue
Closed
opened 2025-12-30 01:27:14 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:27:14 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1028
Author: @bioball
Created: 3/26/2025
Status: ✅ Merged
Merged: 4/15/2025
Merged by: @bioball

Base: main ← Head: fix-pkldoc-package-data-generator

📝 Commits (1)

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 pkl-doc/src/main/kotlin/org/pkl/doc/PackageDataGenerator.kt (+3 -1)

📄 Description

This fixes an issue that can possibly cause a StringIndexOutOfBoundsException when generating pkldoc.

The relative path should be based off the module name prefix, not the package name.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1028 **Author:** [@bioball](https://github.com/bioball) **Created:** 3/26/2025 **Status:** ✅ Merged **Merged:** 4/15/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix-pkldoc-package-data-generator` --- ### 📝 Commits (1) - [`441c0ec`](https://github.com/apple/pkl/commit/441c0ec5da0c8ede9ef2d53e372355e4fbc67cb7) Fix incorrect substring ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/PackageDataGenerator.kt` (+3 -1) </details> ### 📄 Description This fixes an issue that can possibly cause a StringIndexOutOfBoundsException when generating pkldoc. The relative path should be based off the module name prefix, not the package name. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:27:14 +01:00
adam closed this issue 2025-12-30 01:27:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#860
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?