starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 14:20:35 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #1024] [MERGED] move parser out of pkl-core #859

New Issue
Closed
opened 2025-12-30 01:27:14 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:27:14 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1024
Author: @stackoverflow
Created: 3/14/2025
Status: ✅ Merged
Merged: 3/18/2025
Merged by: @stackoverflow

Base: main ← Head: parser-module

📝 Commits (4)

📊 Changes

80 files changed (+906 additions, -739 deletions)

View changed files

📝 build.gradle.kts (+2 -2)
📝 docs/docs.gradle.kts (+2 -1)
📝 docs/src/test/kotlin/DocSnippetTests.kt (+4 -4)
📝 pkl-core/gradle.lockfile (+0 -6)
📝 pkl-core/pkl-core.gradle.kts (+2 -51)
📝 pkl-core/src/main/java/org/pkl/core/PcfRenderer.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/ast/builder/AbstractAstBuilder.java (+6 -6)
📝 pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java (+79 -79)
📝 pkl-core/src/main/java/org/pkl/core/ast/builder/ImportsAndReadsParser.java (+11 -11)
📝 pkl-core/src/main/java/org/pkl/core/ast/builder/SymbolTable.java (+1 -1)
➖ pkl-core/src/main/java/org/pkl/core/parser/package-info.java (+0 -4)
➖ pkl-core/src/main/java/org/pkl/core/parser/syntax/package-info.java (+0 -4)
📝 pkl-core/src/main/java/org/pkl/core/repl/ReplServer.java (+10 -10)
📝 pkl-core/src/main/java/org/pkl/core/runtime/MinPklVersionChecker.java (+4 -4)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmLanguage.java (+3 -3)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmUndefinedValueException.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmUtils.java (+3 -3)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmValueRenderer.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/stdlib/base/PcfRenderer.java (+1 -1)
📝 pkl-core/src/main/resources/org/pkl/core/errorMessages.properties (+0 -125)

...and 60 more files

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1024 **Author:** [@stackoverflow](https://github.com/stackoverflow) **Created:** 3/14/2025 **Status:** ✅ Merged **Merged:** 3/18/2025 **Merged by:** [@stackoverflow](https://github.com/stackoverflow) **Base:** `main` ← **Head:** `parser-module` --- ### 📝 Commits (4) - [`0c16fed`](https://github.com/apple/pkl/commit/0c16fed71aa5f29b73f26267d238764eebba52e0) move parser out of pkl-core - [`72905d2`](https://github.com/apple/pkl/commit/72905d2078e39c99389049e05313023a59aa7913) fix pkl-parser configuration - [`6fea2b7`](https://github.com/apple/pkl/commit/6fea2b70070e121f705f8fb5ff571630e5e74545) fix review remarks - [`28371bf`](https://github.com/apple/pkl/commit/28371bfd48baa706a86719d844b2477227a436d8) remove generator ### 📊 Changes **80 files changed** (+906 additions, -739 deletions) <details> <summary>View changed files</summary> 📝 `build.gradle.kts` (+2 -2) 📝 `docs/docs.gradle.kts` (+2 -1) 📝 `docs/src/test/kotlin/DocSnippetTests.kt` (+4 -4) 📝 `pkl-core/gradle.lockfile` (+0 -6) 📝 `pkl-core/pkl-core.gradle.kts` (+2 -51) 📝 `pkl-core/src/main/java/org/pkl/core/PcfRenderer.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/ast/builder/AbstractAstBuilder.java` (+6 -6) 📝 `pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java` (+79 -79) 📝 `pkl-core/src/main/java/org/pkl/core/ast/builder/ImportsAndReadsParser.java` (+11 -11) 📝 `pkl-core/src/main/java/org/pkl/core/ast/builder/SymbolTable.java` (+1 -1) ➖ `pkl-core/src/main/java/org/pkl/core/parser/package-info.java` (+0 -4) ➖ `pkl-core/src/main/java/org/pkl/core/parser/syntax/package-info.java` (+0 -4) 📝 `pkl-core/src/main/java/org/pkl/core/repl/ReplServer.java` (+10 -10) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/MinPklVersionChecker.java` (+4 -4) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmLanguage.java` (+3 -3) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmUndefinedValueException.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmUtils.java` (+3 -3) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmValueRenderer.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/stdlib/base/PcfRenderer.java` (+1 -1) 📝 `pkl-core/src/main/resources/org/pkl/core/errorMessages.properties` (+0 -125) _...and 60 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:27:14 +01:00
adam closed this issue 2025-12-30 01:27:14 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#859
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?