starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 23:23:37 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #1013] [MERGED] Add optimization for generator bodies that don't introduce new members #852

New Issue
Closed
opened 2025-12-30 01:27:12 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:27:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1013
Author: @bioball
Created: 3/5/2025
Status: ✅ Merged
Merged: 3/5/2025
Merged by: @bioball

Base: main ← Head: optimized-generators

📝 Commits (2)

  • cfc487f Add optimization for generator bodies that don't introduce new members
  • 52a538c Update generatorNoMembers.pkl

📊 Changes

4 files changed (+94 additions, -0 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/ast/expression/generator/GeneratorObjectLiteralNode.java (+24 -0)
📝 pkl-core/src/main/java/org/pkl/core/ast/expression/generator/ObjectData.java (+4 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/generators/generatorNoMembers.pkl (+46 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/generators/generatorNoMembers.err (+20 -0)

📄 Description

If a generator object literal doesn't add any object members, we can simply use the parent in its place.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1013 **Author:** [@bioball](https://github.com/bioball) **Created:** 3/5/2025 **Status:** ✅ Merged **Merged:** 3/5/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `optimized-generators` --- ### 📝 Commits (2) - [`cfc487f`](https://github.com/apple/pkl/commit/cfc487f088fc366f1892070d16a91a085f8752c0) Add optimization for generator bodies that don't introduce new members - [`52a538c`](https://github.com/apple/pkl/commit/52a538c39d64041a08f6b81a71e01918e5ce34e8) Update generatorNoMembers.pkl ### 📊 Changes **4 files changed** (+94 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/generator/GeneratorObjectLiteralNode.java` (+24 -0) 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/generator/ObjectData.java` (+4 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/generators/generatorNoMembers.pkl` (+46 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/generators/generatorNoMembers.err` (+20 -0) </details> ### 📄 Description If a generator object literal doesn't add any object members, we can simply use the parent in its place. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:27:12 +01:00
adam closed this issue 2025-12-30 01:27:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#852
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?