[PR #998] [MERGED] Fix shadow jar logic #843

New Issue

adam · 2025-12-30T01:27:09+01:00

adam commented

2025-12-30 01:27:09 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/998
Author: @bioball
Created: 2/28/2025
Status: ✅ Merged
Merged: 3/3/2025
Merged by: @bioball

Base: main ← Head: test-shadow-jar

📝 Commits (4)

c7dc6b4 Add logic to test start shadow jar
d207787 Fix shadow jar
8f83edc Add test for relocations, fix other relocations
da3f99a Don't use internal Gradle API

📊 Changes

2 files changed (+78 additions, -6 deletions)

View changed files

📝 buildSrc/src/main/kotlin/pklFatJar.gradle.kts (+19 -6)
📝 pkl-tools/pkl-tools.gradle.kts (+59 -0)

📄 Description

Also, add some logic to test start the shadow jar.

Fixes #999

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/998 **Author:** [@bioball](https://github.com/bioball) **Created:** 2/28/2025 **Status:** ✅ Merged **Merged:** 3/3/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `test-shadow-jar` --- ### 📝 Commits (4) - [`c7dc6b4`](https://github.com/apple/pkl/commit/c7dc6b44d4369df646c296477b86ab253fa3ee68) Add logic to test start shadow jar - [`d207787`](https://github.com/apple/pkl/commit/d207787107a571e7ebec38589b7a51caedd8f8e3) Fix shadow jar - [`8f83edc`](https://github.com/apple/pkl/commit/8f83edcef91d4a09e18129e5e2eddcf20696b6e4) Add test for relocations, fix other relocations - [`da3f99a`](https://github.com/apple/pkl/commit/da3f99ac3c51b6b07b5f4a22adbeadcef1d06d91) Don't use internal Gradle API ### 📊 Changes **2 files changed** (+78 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `buildSrc/src/main/kotlin/pklFatJar.gradle.kts` (+19 -6) 📝 `pkl-tools/pkl-tools.gradle.kts` (+59 -0) </details> ### 📄 Description Also, add some logic to test start the shadow jar. Fixes #999 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:09 +01:00

adam closed this issue

2025-12-30 01:27:09 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#843