[PR #941] [MERGED] Correctly set allowed modules/resoures when external reader scheme contain regex control characters #820

New Issue

adam · 2025-12-30T01:27:00+01:00

adam commented

2025-12-30 01:27:00 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/941
Author: @HT154
Created: 2/6/2025
Status: ✅ Merged
Merged: 2/7/2025
Merged by: @bioball

Base: main ← Head: escape-auto-external-reader-schemes

📝 Commits (1)

f266e5f Correctly set allowed modules/resoures when external reader scheme contain regex control characters

📊 Changes

3 files changed (+95 additions, -19 deletions)

View changed files

📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliCommand.kt (+17 -15)
📝 pkl-commons-cli/src/test/kotlin/org/pkl/commons/cli/BaseCommandTest.kt (+10 -4)
➕ pkl-commons-cli/src/test/kotlin/org/pkl/commons/cli/CliCommandTest.kt (+68 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/941 **Author:** [@HT154](https://github.com/HT154) **Created:** 2/6/2025 **Status:** ✅ Merged **Merged:** 2/7/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `escape-auto-external-reader-schemes` --- ### 📝 Commits (1) - [`f266e5f`](https://github.com/apple/pkl/commit/f266e5f0888c20189cdde90d6b2ca869bcbdd457) Correctly set allowed modules/resoures when external reader scheme contain regex control characters ### 📊 Changes **3 files changed** (+95 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliCommand.kt` (+17 -15) 📝 `pkl-commons-cli/src/test/kotlin/org/pkl/commons/cli/BaseCommandTest.kt` (+10 -4) ➕ `pkl-commons-cli/src/test/kotlin/org/pkl/commons/cli/CliCommandTest.kt` (+68 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:00 +01:00

adam closed this issue

2025-12-30 01:27:01 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#820