starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #936] [MERGED] Remove usages of VmFunction#apply(Object) #815

New Issue
Closed
opened 2025-12-30 01:26:58 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:58 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/936
Author: @bioball
Created: 2/5/2025
Status: ✅ Merged
Merged: 2/5/2025
Merged by: @bioball

Base: main ← Head: vmfunction-apply

📝 Commits (1)

  • 76c352d Remove usages of VmFunction#apply(Object)

📊 Changes

3 files changed (+19 additions, -17 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/ast/expression/member/ReadSuperEntryNode.java (+5 -2)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmFunction.java (+0 -9)
📝 pkl-core/src/main/java/org/pkl/core/stdlib/base/StringNodes.java (+14 -6)

📄 Description

These call sites should use ApplyVmFunction1Node instead.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/936 **Author:** [@bioball](https://github.com/bioball) **Created:** 2/5/2025 **Status:** ✅ Merged **Merged:** 2/5/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `vmfunction-apply` --- ### 📝 Commits (1) - [`76c352d`](https://github.com/apple/pkl/commit/76c352dd7112d754ab389102cd6de1761289e5d6) Remove usages of VmFunction#apply(Object) ### 📊 Changes **3 files changed** (+19 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/member/ReadSuperEntryNode.java` (+5 -2) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmFunction.java` (+0 -9) 📝 `pkl-core/src/main/java/org/pkl/core/stdlib/base/StringNodes.java` (+14 -6) </details> ### 📄 Description These call sites should use `ApplyVmFunction1Node` instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:58 +01:00
adam closed this issue 2025-12-30 01:26:58 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#815
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?