[PR #914] [MERGED] fix: downstream native-image builds #799

New Issue

adam · 2025-12-30T01:26:52+01:00

adam commented

2025-12-30 01:26:52 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/914
Author: @sgammon
Created: 1/28/2025
Status: ✅ Merged
Merged: 1/30/2025
Merged by: @bioball

Base: main ← Head: fix/nativeimage-build

📝 Commits (1)

5dbdbe9 fix: downstream native-image builds

📊 Changes

2 files changed (+12 additions, -14 deletions)

View changed files

📝 buildSrc/src/main/kotlin/pklFatJar.gradle.kts (+4 -1)
📝 pkl-cli/pkl-cli.gradle.kts (+8 -13)

📄 Description

Summary

SVM (SubstrateVM) compile configuration classes must be included within the cli jar to prevent downstream native-image builds from failing. Fat JARs cannot be used with native-image, so these classes can still safely be excluded here.

Fixes and closes apple/pkl#907

Changelog

fix: don't exclude svm classes from cli jar
fix: include svm exclusions in fatjar config

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/914 **Author:** [@sgammon](https://github.com/sgammon) **Created:** 1/28/2025 **Status:** ✅ Merged **Merged:** 1/30/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix/nativeimage-build` --- ### 📝 Commits (1) - [`5dbdbe9`](https://github.com/apple/pkl/commit/5dbdbe9bb8c1cecc1fac24aa55c26d1bc1ad18e9) fix: downstream `native-image` builds ### 📊 Changes **2 files changed** (+12 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `buildSrc/src/main/kotlin/pklFatJar.gradle.kts` (+4 -1) 📝 `pkl-cli/pkl-cli.gradle.kts` (+8 -13) </details> ### 📄 Description ## Summary SVM (SubstrateVM) compile configuration classes must be included within the `cli` jar to prevent downstream `native-image` builds from failing. Fat JARs cannot be used with `native-image`, so these classes can still safely be excluded here. Fixes and closes apple/pkl#907 ## Changelog - fix: don't exclude svm classes from `cli` jar - fix: include svm exclusions in fatjar config --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:26:52 +01:00

adam closed this issue

2025-12-30 01:26:52 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#799

[PR #914] [MERGED] fix: downstream native-image builds #799