[PR #872] [MERGED] Support jpkl executable for Windows #780

New Issue

adam · 2025-12-30T01:26:41+01:00

adam commented

2025-12-30 01:26:41 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/872
Author: @bioball
Created: 1/3/2025
Status: ✅ Merged
Merged: 1/14/2025
Merged by: @bioball

Base: main ← Head: jpkl-for-windows

📝 Commits (3)

21dc4bf Support jpkl exeuctable for windows
6d259fa Polish docs
0bbf2b9 Update copyright years, update description

📊 Changes

3 files changed (+45 additions, -17 deletions)

View changed files

📝 buildSrc/src/main/kotlin/ExecutableJar.kt (+23 -9)
📝 docs/modules/pkl-cli/pages/index.adoc (+20 -6)
📝 pkl-cli/pkl-cli.gradle.kts (+2 -2)

📄 Description

This updates the script used to start the executable to support Windows as well.

For Windows support, the executable needs to be named jpkl.bat.

No unit tests here, but this is tested on macOS directly, and on Windows in my Parallels instance.

This follows a technique shown by this blog post: https://mill-build.org/blog/5-executable-jars.html. Thanks, @lihaoyi!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/872 **Author:** [@bioball](https://github.com/bioball) **Created:** 1/3/2025 **Status:** ✅ Merged **Merged:** 1/14/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `jpkl-for-windows` --- ### 📝 Commits (3) - [`21dc4bf`](https://github.com/apple/pkl/commit/21dc4bfbd50a1d5f8f29a45df4bc31a35015bbb0) Support jpkl exeuctable for windows - [`6d259fa`](https://github.com/apple/pkl/commit/6d259faa6662643cdc71683cec9bc838489d0690) Polish docs - [`0bbf2b9`](https://github.com/apple/pkl/commit/0bbf2b96bc4774ca2ddd30b12ac0d7eab55b3fd3) Update copyright years, update description ### 📊 Changes **3 files changed** (+45 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `buildSrc/src/main/kotlin/ExecutableJar.kt` (+23 -9) 📝 `docs/modules/pkl-cli/pages/index.adoc` (+20 -6) 📝 `pkl-cli/pkl-cli.gradle.kts` (+2 -2) </details> ### 📄 Description This updates the script used to start the executable to support Windows as well. For Windows support, the executable needs to be named `jpkl.bat`. No unit tests here, but this is tested on macOS directly, and on Windows in my Parallels instance. This follows a technique shown by this blog post: https://mill-build.org/blog/5-executable-jars.html. Thanks, @lihaoyi! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:26:41 +01:00

adam closed this issue

2025-12-30 01:26:41 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#780