starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-14 15:43:41 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #851] [MERGED] Download JDK for windows build #774

New Issue
Closed
opened 2025-12-30 01:26:39 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:39 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/851
Author: @bioball
Created: 12/18/2024
Status: ✅ Merged
Merged: 12/19/2024
Merged by: @bioball

Base: main ← Head: fix-windows-build

📝 Commits (7)

📊 Changes

7 files changed (+123 additions, -58 deletions)

View changed files

📝 .circleci/config.pkl (+2 -0)
📝 .circleci/config.yml (+55 -16)
📝 .circleci/jobs/BuildNativeJob.pkl (+10 -10)
📝 .circleci/jobs/DeployJob.pkl (+2 -6)
📝 .circleci/jobs/GradleCheckJob.pkl (+0 -20)
📝 .circleci/jobs/GradleJob.pkl (+52 -0)
📝 .circleci/jobs/SimpleGradleJob.pkl (+2 -6)

📄 Description

Don't use the system Java on Windows builds, instead download them from Adoptium.

Also:

  • Fail job if curl returns a 4xx status code
  • Add java version to GradleJob

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/851 **Author:** [@bioball](https://github.com/bioball) **Created:** 12/18/2024 **Status:** ✅ Merged **Merged:** 12/19/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix-windows-build` --- ### 📝 Commits (7) - [`06cc5bb`](https://github.com/apple/pkl/commit/06cc5bbc3ab9118c5dd372513719e358981b318e) Download JDK for windows build - [`d35c0d0`](https://github.com/apple/pkl/commit/d35c0d0e9fbd02e6f3ffd6fae002b70341730e1c) More adjustments - [`d9aa215`](https://github.com/apple/pkl/commit/d9aa2158dacebd490a3c1a1728545891358caf69) Try again - [`9e324a2`](https://github.com/apple/pkl/commit/9e324a2562e9717cb6c924ba58a2d17a0f8095b6) Try again - [`765b62d`](https://github.com/apple/pkl/commit/765b62d06fd12d4dfa2fbfe9a0137d6b043f3922) Reset PRB job names - [`94f0102`](https://github.com/apple/pkl/commit/94f01024e77c92f5ca38bae9ae657c6de5f2b0df) Fix release name - [`a8305c2`](https://github.com/apple/pkl/commit/a8305c2dc992c977265cc82f6a63f9ae4684ccf5) Fix release name ### 📊 Changes **7 files changed** (+123 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `.circleci/config.pkl` (+2 -0) 📝 `.circleci/config.yml` (+55 -16) 📝 `.circleci/jobs/BuildNativeJob.pkl` (+10 -10) 📝 `.circleci/jobs/DeployJob.pkl` (+2 -6) 📝 `.circleci/jobs/GradleCheckJob.pkl` (+0 -20) 📝 `.circleci/jobs/GradleJob.pkl` (+52 -0) 📝 `.circleci/jobs/SimpleGradleJob.pkl` (+2 -6) </details> ### 📄 Description Don't use the system Java on Windows builds, instead download them from Adoptium. Also: * Fail job if curl returns a 4xx status code * Add java version to `GradleJob` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:39 +01:00
adam closed this issue 2025-12-30 01:26:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#774
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?