starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #822] [CLOSED] Fix: check computed members against listing/mapping owner #757

New Issue
Closed
opened 2025-12-30 01:26:34 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:34 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/822
Author: @bioball
Created: 11/17/2024
Status: ❌ Closed

Base: main ← Head: mapping-listing-typecheck-fix

📝 Commits (1)

  • 6e1d857 Fix: check computed members against listing/mapping owner

📊 Changes

3 files changed (+24 additions, -0 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/runtime/VmUtils.java (+3 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/errors/listingTypeCheckError8.pkl (+6 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/errors/listingTypeCheckError8.err (+15 -0)

📄 Description

This addresses a regression where a value can possibly not be type-casted correctly.

Closes https://github.com/apple/pkl/issues/785

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/822 **Author:** [@bioball](https://github.com/bioball) **Created:** 11/17/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `mapping-listing-typecheck-fix` --- ### 📝 Commits (1) - [`6e1d857`](https://github.com/apple/pkl/commit/6e1d8571d543905879b6abf4ed7f293d37863a8f) Fix: check computed members against listing/mapping owner ### 📊 Changes **3 files changed** (+24 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmUtils.java` (+3 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/errors/listingTypeCheckError8.pkl` (+6 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/errors/listingTypeCheckError8.err` (+15 -0) </details> ### 📄 Description This addresses a regression where a value can possibly not be type-casted correctly. Closes https://github.com/apple/pkl/issues/785 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:34 +01:00
adam closed this issue 2025-12-30 01:26:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#757
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?