[PR #822] [CLOSED] Fix: check computed members against listing/mapping owner #757

New Issue

Closed

opened 2025-12-30 01:26:34 +01:00 by adam · 0 comments

adam commented 2025-12-30 01:26:34 +01:00

Owner

Copy Link

Copy Source

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/822
Author: @bioball
Created: 11/17/2024
Status: ❌ Closed

Base: main ← Head: mapping-listing-typecheck-fix

---

📝 Commits (1)

• 6e1d857 Fix: check computed members against listing/mapping owner

📊 Changes

3 files changed (+24 additions, -0 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/runtime/VmUtils.java (+3 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/errors/listingTypeCheckError8.pkl (+6 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/errors/listingTypeCheckError8.err (+15 -0)

📄 Description

This addresses a regression where a value can possibly not be type-casted correctly.

Closes https://github.com/apple/pkl/issues/785

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/822 **Author:** [@bioball](https://github.com/bioball) **Created:** 11/17/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `mapping-listing-typecheck-fix` --- ### 📝 Commits (1) - [`6e1d857`](https://github.com/apple/pkl/commit/6e1d8571d543905879b6abf4ed7f293d37863a8f) Fix: check computed members against listing/mapping owner ### 📊 Changes **3 files changed** (+24 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmUtils.java` (+3 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/errors/listingTypeCheckError8.pkl` (+6 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/errors/listingTypeCheckError8.err` (+15 -0) </details> ### 📄 Description This addresses a regression where a value can possibly not be type-casted correctly. Closes https://github.com/apple/pkl/issues/785 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

adam added the pull-request label 2025-12-30 01:26:34 +01:00

adam closed this issue 2025-12-30 01:26:34 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

dependabot/github_actions/gradle/actions/dependency-submission-6.2.0

release/0.32

dependabot/gradle/com.squareup-kotlinpoet-2.3.0

truffle-object-model-clean

release/0.31

release/0.30

release/0.29

release/0.28

release/0.27

release/0.26

release/0.25

0.32.1

0.32.0

0.31.1

0.31.0

0.30.2

0.30.1

0.30.0

0.29.1

0.29.0

0.28.2

0.28.1

0.28.0

0.27.2

0.27.1

0.27.0

0.26.3

0.26.2

0.26.1

0.26.0

0.25.3

0.25.2

0.25.1

0.25.0

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

pull-request

Mirrored from GitHub Pull Request

No labels pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

adam (Adam Melkus)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#757