[PR #810] [MERGED] codegen-kotlin: Deprecate method toKotlinCodegenOptions without replacement #749

Closed
opened 2025-12-30 01:26:31 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/810
Author: @odenix
Created: 11/14/2024
Status: Merged
Merged: 11/14/2024
Merged by: @bioball

Base: mainHead: to-kotlin-codegen-options


📝 Commits (1)

  • a5b872e codegen-kotlin: Deprecate method toKotlinCodegenOptions without replacement

📊 Changes

2 files changed (+6 additions, -2 deletions)

View changed files

📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGenerator.kt (+1 -1)
📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorOptions.kt (+5 -1)

📄 Description

Motivation:
CliKotlinCodeGeneratorOptions.toKotlinCodegenOptions is an internal method that isn't useful to clients.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/810 **Author:** [@odenix](https://github.com/odenix) **Created:** 11/14/2024 **Status:** ✅ Merged **Merged:** 11/14/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `to-kotlin-codegen-options` --- ### 📝 Commits (1) - [`a5b872e`](https://github.com/apple/pkl/commit/a5b872e5fc9b2ef05fd69ed2d18d6092100771ca) codegen-kotlin: Deprecate method `toKotlinCodegenOptions` without replacement ### 📊 Changes **2 files changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGenerator.kt` (+1 -1) 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGeneratorOptions.kt` (+5 -1) </details> ### 📄 Description Motivation: `CliKotlinCodeGeneratorOptions.toKotlinCodegenOptions` is an internal method that isn't useful to clients. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:31 +01:00
adam closed this issue 2025-12-30 01:26:31 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#749