starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 15:13:38 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #812] [MERGED] Continue conversion of org.pkl.core POJOs to record classes #747

New Issue
Closed
opened 2025-12-30 01:26:31 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:31 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/812
Author: @odenix
Created: 11/14/2024
Status: ✅ Merged
Merged: 11/14/2024
Merged by: @bioball

Base: main ← Head: pojos

📝 Commits (1)

  • 2b94d16 Continue conversion of org.pkl.core POJOs to record classes

📊 Changes

5 files changed (+56 additions, -101 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/Member.java (+6 -0)
📝 pkl-core/src/main/java/org/pkl/core/Platform.java (+13 -7)
📝 pkl-core/src/main/java/org/pkl/core/Release.java (+35 -92)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/CliDocGenerator.kt (+1 -1)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/DocScope.kt (+1 -1)

📄 Description

Note: The handwritten (now deleted) equals and hashCode methods of class org.pkl.core.Release didn't include components os and flavor. I suspect this was an oversight.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/812 **Author:** [@odenix](https://github.com/odenix) **Created:** 11/14/2024 **Status:** ✅ Merged **Merged:** 11/14/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `pojos` --- ### 📝 Commits (1) - [`2b94d16`](https://github.com/apple/pkl/commit/2b94d167ec530305b70410444014430427d40030) Continue conversion of org.pkl.core POJOs to record classes ### 📊 Changes **5 files changed** (+56 additions, -101 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/Member.java` (+6 -0) 📝 `pkl-core/src/main/java/org/pkl/core/Platform.java` (+13 -7) 📝 `pkl-core/src/main/java/org/pkl/core/Release.java` (+35 -92) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/CliDocGenerator.kt` (+1 -1) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/DocScope.kt` (+1 -1) </details> ### 📄 Description Note: The handwritten (now deleted) `equals` and `hashCode` methods of class `org.pkl.core.Release` didn't include components `os` and `flavor`. I suspect this was an oversight. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:31 +01:00
adam closed this issue 2025-12-30 01:26:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#747
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?