starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #801] [MERGED] Rename JavaCodegenOptions to JavaCodeGeneratorOptions #744

New Issue
Closed
opened 2025-12-30 01:26:29 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:29 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/801
Author: @odenix
Created: 11/12/2024
Status: ✅ Merged
Merged: 11/14/2024
Merged by: @bioball

Base: main ← Head: java-codegen-rename

📝 Commits (2)

  • ff4b41f Rename JavaCodegenOptions to JavaCodeGeneratorOptions
  • 2088ed8 Deprecate CliJavaCodeGeneratorOptions.toJavaCodegenOptions()

📊 Changes

4 files changed (+22 additions, -13 deletions)

View changed files

📝 pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/CliJavaCodeGenerator.kt (+1 -1)
📝 pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/CliJavaCodeGeneratorOptions.kt (+6 -2)
📝 pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/JavaCodeGenerator.kt (+5 -2)
📝 pkl-codegen-java/src/test/kotlin/org/pkl/codegen/java/JavaCodeGeneratorTest.kt (+10 -8)

📄 Description

The new name is consistent with existing names JavaCodeGenerator and CliJavaCodeGeneratorOptions.
Backward compatibility is ensured by turning JavaCodegenOptions into a (deprecated) type alias.

Second commit: Deprecate CliJavaCodeGeneratorOptions.toJavaCodegenOptions()
I suspect this method was a public API by accident.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/801 **Author:** [@odenix](https://github.com/odenix) **Created:** 11/12/2024 **Status:** ✅ Merged **Merged:** 11/14/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `java-codegen-rename` --- ### 📝 Commits (2) - [`ff4b41f`](https://github.com/apple/pkl/commit/ff4b41f6eeb5dbcf6f486790aa08888ddacfa54f) Rename JavaCodegenOptions to JavaCodeGeneratorOptions - [`2088ed8`](https://github.com/apple/pkl/commit/2088ed820f00f5ef9684d62da6313e212301325a) Deprecate CliJavaCodeGeneratorOptions.toJavaCodegenOptions() ### 📊 Changes **4 files changed** (+22 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/CliJavaCodeGenerator.kt` (+1 -1) 📝 `pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/CliJavaCodeGeneratorOptions.kt` (+6 -2) 📝 `pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/JavaCodeGenerator.kt` (+5 -2) 📝 `pkl-codegen-java/src/test/kotlin/org/pkl/codegen/java/JavaCodeGeneratorTest.kt` (+10 -8) </details> ### 📄 Description The new name is consistent with existing names `JavaCodeGenerator` and `CliJavaCodeGeneratorOptions`. Backward compatibility is ensured by turning `JavaCodegenOptions` into a (deprecated) type alias. Second commit: Deprecate `CliJavaCodeGeneratorOptions.toJavaCodegenOptions()` I suspect this method was a public API by accident. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:29 +01:00
adam closed this issue 2025-12-30 01:26:30 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#744
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?