[PR #779] [MERGED] Polish ANSI formatting and underlying code #730

New Issue

adam · 2025-12-30T01:26:24+01:00

adam commented

2025-12-30 01:26:24 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/779
Author: @odenix
Created: 11/5/2024
Status: ✅ Merged
Merged: 11/5/2024
Merged by: @bioball

Base: main ← Head: ansi

📝 Commits (1)

855a24a Polish ANSI formatting and underlying code

📊 Changes

9 files changed (+57 additions, -58 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/runtime/StackTraceRenderer.java (+7 -7)
📝 pkl-core/src/main/java/org/pkl/core/runtime/TestRunner.java (+7 -6)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmExceptionRenderer.java (+5 -5)
📝 pkl-core/src/main/java/org/pkl/core/stdlib/test/report/SimpleReport.java (+8 -8)
📝 pkl-core/src/main/java/org/pkl/core/util/AnsiStringBuilder.java (+17 -19)
📝 pkl-core/src/main/java/org/pkl/core/util/AnsiTheme.java (+2 -2)
📝 pkl-core/src/main/java/org/pkl/core/util/StringUtils.java (+1 -2)
📝 pkl-core/src/test/kotlin/org/pkl/core/runtime/StackTraceRendererTest.kt (+2 -1)
📝 pkl-core/src/test/kotlin/org/pkl/core/util/AnsiStringBuilderTest.kt (+8 -8)

📄 Description

change line numbers from blue to faint to improve legibility on dark backgrounds
use EnumSet throughout
move all ANSI classes into package core.util (no need to split them over util and runtime)
rename AnsiCodingStringBuilder to AnsiStringBuilder

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/779 **Author:** [@odenix](https://github.com/odenix) **Created:** 11/5/2024 **Status:** ✅ Merged **Merged:** 11/5/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `ansi` --- ### 📝 Commits (1) - [`855a24a`](https://github.com/apple/pkl/commit/855a24adeb34071ddc561107210e7f90735d6b17) Polish ANSI formatting and underlying code ### 📊 Changes **9 files changed** (+57 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/runtime/StackTraceRenderer.java` (+7 -7) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/TestRunner.java` (+7 -6) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmExceptionRenderer.java` (+5 -5) 📝 `pkl-core/src/main/java/org/pkl/core/stdlib/test/report/SimpleReport.java` (+8 -8) 📝 `pkl-core/src/main/java/org/pkl/core/util/AnsiStringBuilder.java` (+17 -19) 📝 `pkl-core/src/main/java/org/pkl/core/util/AnsiTheme.java` (+2 -2) 📝 `pkl-core/src/main/java/org/pkl/core/util/StringUtils.java` (+1 -2) 📝 `pkl-core/src/test/kotlin/org/pkl/core/runtime/StackTraceRendererTest.kt` (+2 -1) 📝 `pkl-core/src/test/kotlin/org/pkl/core/util/AnsiStringBuilderTest.kt` (+8 -8) </details> ### 📄 Description - change line numbers from blue to faint to improve legibility on dark backgrounds - use EnumSet throughout - move all ANSI classes into package core.util (no need to split them over util and runtime) - rename AnsiCodingStringBuilder to AnsiStringBuilder --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:26:24 +01:00

adam closed this issue

2025-12-30 01:26:25 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#730