[PR #778] [MERGED] Eagerly check function arguments when called from inside iterable #729

New Issue

adam · 2025-12-30T01:26:24+01:00

adam commented

2025-12-30 01:26:24 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/778
Author: @bioball
Created: 11/4/2024
Status: ✅ Merged
Merged: 11/5/2024
Merged by: @bioball

Base: main ← Head: eager-check-iterables

📝 Commits (2)

a23b8f8 Eagerly check function arguments when called from inside iterable
b2f400d Add additional comment

📊 Changes

22 files changed (+215 additions, -49 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java (+9 -2)
📝 pkl-core/src/main/java/org/pkl/core/ast/expression/binary/LetExprNode.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/ast/expression/literal/AmendFunctionNode.java (+2 -1)
📝 pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeMethodDirectNode.java (+7 -3)
📝 pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeMethodLexicalNode.java (+7 -3)
📝 pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeMethodVirtualNode.java (+20 -11)
📝 pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeSuperMethodNode.java (+6 -2)
📝 pkl-core/src/main/java/org/pkl/core/ast/expression/member/ResolveMethodNode.java (+18 -5)
📝 pkl-core/src/main/java/org/pkl/core/ast/internal/ToStringNode.java (+1 -0)
📝 pkl-core/src/main/java/org/pkl/core/ast/lambda/ApplyVmFunction0Node.java (+2 -2)
📝 pkl-core/src/main/java/org/pkl/core/ast/lambda/ApplyVmFunction1Node.java (+2 -2)
📝 pkl-core/src/main/java/org/pkl/core/ast/lambda/ApplyVmFunction2Node.java (+3 -2)
📝 pkl-core/src/main/java/org/pkl/core/ast/lambda/ApplyVmFunction3Node.java (+2 -2)
📝 pkl-core/src/main/java/org/pkl/core/ast/lambda/ApplyVmFunction4Node.java (+2 -2)
📝 pkl-core/src/main/java/org/pkl/core/ast/lambda/ApplyVmFunction5Node.java (+10 -2)
📝 pkl-core/src/main/java/org/pkl/core/ast/member/FunctionNode.java (+11 -2)
📝 pkl-core/src/main/java/org/pkl/core/ast/type/IdentityMixinNode.java (+3 -3)
📝 pkl-core/src/main/java/org/pkl/core/ast/type/TypeNode.java (+70 -0)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmFunction.java (+2 -2)
📝 pkl-core/src/main/java/org/pkl/core/stdlib/base/FunctionNodes.java (+3 -2)

...and 2 more files

📄 Description

This mitigates an issue where lazy mappings and listings widen an existing bug.

This is a follow-up to https://github.com/apple/pkl/pull/752.

Ideally, when we fix the scoping bug, we also revert this commit.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/778 **Author:** [@bioball](https://github.com/bioball) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 11/5/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `eager-check-iterables` --- ### 📝 Commits (2) - [`a23b8f8`](https://github.com/apple/pkl/commit/a23b8f87e05d7a092d316ffb6eafd3f5a205607d) Eagerly check function arguments when called from inside iterable - [`b2f400d`](https://github.com/apple/pkl/commit/b2f400da9919915a411e2e110f33a02da501db3b) Add additional comment ### 📊 Changes **22 files changed** (+215 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java` (+9 -2) 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/binary/LetExprNode.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/literal/AmendFunctionNode.java` (+2 -1) 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeMethodDirectNode.java` (+7 -3) 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeMethodLexicalNode.java` (+7 -3) 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeMethodVirtualNode.java` (+20 -11) 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/member/InvokeSuperMethodNode.java` (+6 -2) 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/member/ResolveMethodNode.java` (+18 -5) 📝 `pkl-core/src/main/java/org/pkl/core/ast/internal/ToStringNode.java` (+1 -0) 📝 `pkl-core/src/main/java/org/pkl/core/ast/lambda/ApplyVmFunction0Node.java` (+2 -2) 📝 `pkl-core/src/main/java/org/pkl/core/ast/lambda/ApplyVmFunction1Node.java` (+2 -2) 📝 `pkl-core/src/main/java/org/pkl/core/ast/lambda/ApplyVmFunction2Node.java` (+3 -2) 📝 `pkl-core/src/main/java/org/pkl/core/ast/lambda/ApplyVmFunction3Node.java` (+2 -2) 📝 `pkl-core/src/main/java/org/pkl/core/ast/lambda/ApplyVmFunction4Node.java` (+2 -2) 📝 `pkl-core/src/main/java/org/pkl/core/ast/lambda/ApplyVmFunction5Node.java` (+10 -2) 📝 `pkl-core/src/main/java/org/pkl/core/ast/member/FunctionNode.java` (+11 -2) 📝 `pkl-core/src/main/java/org/pkl/core/ast/type/IdentityMixinNode.java` (+3 -3) 📝 `pkl-core/src/main/java/org/pkl/core/ast/type/TypeNode.java` (+70 -0) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmFunction.java` (+2 -2) 📝 `pkl-core/src/main/java/org/pkl/core/stdlib/base/FunctionNodes.java` (+3 -2) _...and 2 more files_ </details> ### 📄 Description This mitigates an issue where lazy mappings and listings widen an existing bug. This is a follow-up to https://github.com/apple/pkl/pull/752. Ideally, when we fix the scoping bug, we also revert this commit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:26:24 +01:00

adam closed this issue

2025-12-30 01:26:24 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#729