[PR #776] [MERGED] Untangle external reader code #728

New Issue

adam · 2025-12-30T01:26:24+01:00

adam commented

2025-12-30 01:26:24 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/776
Author: @odenix
Created: 11/4/2024
Status: ✅ Merged
Merged: 2/21/2025
Merged by: @bioball

Base: main ← Head: untangle

📝 Commits (4)

da140d0 Untangle external reader code
6a91cd4 Strip "External" from class names in package externalreader
d893176 Fix compile errors, and run spotless apply
3ef4c31 Undo some renames

📊 Changes

31 files changed (+218 additions, -212 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/evaluatorSettings/PklEvaluatorSettings.java (+9 -3)
📝 pkl-core/src/main/java/org/pkl/core/externalreader/ExternalModuleResolver.java (+6 -11)
📝 pkl-core/src/main/java/org/pkl/core/externalreader/ExternalModuleResolverImpl.java (+7 -5)
📝 pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderMessagePackDecoder.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderMessages.java (+6 -8)
📝 pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderProcess.java (+5 -5)
📝 pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderProcessImpl.java (+26 -17)
📝 pkl-core/src/main/java/org/pkl/core/externalreader/ExternalResourceResolver.java (+5 -9)
📝 pkl-core/src/main/java/org/pkl/core/externalreader/ExternalResourceResolverImpl.java (+7 -5)
➕ pkl-core/src/main/java/org/pkl/core/externalreader/ModuleReaderSpec.java (+19 -0)
➕ pkl-core/src/main/java/org/pkl/core/externalreader/ResourceReaderSpec.java (+18 -0)
📝 pkl-core/src/main/java/org/pkl/core/messaging/Messages.java (+4 -7)
📝 pkl-core/src/main/java/org/pkl/core/module/ModuleKeyFactories.java (+2 -1)
📝 pkl-core/src/main/java/org/pkl/core/module/ModuleKeys.java (+6 -4)
📝 pkl-core/src/main/java/org/pkl/core/resource/ResourceReaders.java (+6 -5)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmImportAnalyzer.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/stdlib/analyze/AnalyzeNodes.java (+5 -1)
📝 pkl-core/src/test/kotlin/org/pkl/core/externalreader/ExternalModuleReader.kt (+2 -2)
📝 pkl-core/src/test/kotlin/org/pkl/core/externalreader/ExternalReaderClient.kt (+8 -7)
📝 pkl-core/src/test/kotlin/org/pkl/core/externalreader/ExternalResourceReader.kt (+2 -2)

...and 11 more files

📄 Description

See commit messages for details. Second commit is a pure rename refactoring.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/776 **Author:** [@odenix](https://github.com/odenix) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 2/21/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `untangle` --- ### 📝 Commits (4) - [`da140d0`](https://github.com/apple/pkl/commit/da140d0ea187e5d699ed4014a5587e4b64879eb4) Untangle external reader code - [`6a91cd4`](https://github.com/apple/pkl/commit/6a91cd4ed2b26eef32ec7fc5c9f1a8326181c3f8) Strip "External" from class names in package externalreader - [`d893176`](https://github.com/apple/pkl/commit/d893176d8cb12639ba12d216f0e68de72e8513cf) Fix compile errors, and run spotless apply - [`3ef4c31`](https://github.com/apple/pkl/commit/3ef4c319abbac65d48da22a7c69bbc36f66c037f) Undo some renames ### 📊 Changes **31 files changed** (+218 additions, -212 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/evaluatorSettings/PklEvaluatorSettings.java` (+9 -3) 📝 `pkl-core/src/main/java/org/pkl/core/externalreader/ExternalModuleResolver.java` (+6 -11) 📝 `pkl-core/src/main/java/org/pkl/core/externalreader/ExternalModuleResolverImpl.java` (+7 -5) 📝 `pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderMessagePackDecoder.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderMessages.java` (+6 -8) 📝 `pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderProcess.java` (+5 -5) 📝 `pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderProcessImpl.java` (+26 -17) 📝 `pkl-core/src/main/java/org/pkl/core/externalreader/ExternalResourceResolver.java` (+5 -9) 📝 `pkl-core/src/main/java/org/pkl/core/externalreader/ExternalResourceResolverImpl.java` (+7 -5) ➕ `pkl-core/src/main/java/org/pkl/core/externalreader/ModuleReaderSpec.java` (+19 -0) ➕ `pkl-core/src/main/java/org/pkl/core/externalreader/ResourceReaderSpec.java` (+18 -0) 📝 `pkl-core/src/main/java/org/pkl/core/messaging/Messages.java` (+4 -7) 📝 `pkl-core/src/main/java/org/pkl/core/module/ModuleKeyFactories.java` (+2 -1) 📝 `pkl-core/src/main/java/org/pkl/core/module/ModuleKeys.java` (+6 -4) 📝 `pkl-core/src/main/java/org/pkl/core/resource/ResourceReaders.java` (+6 -5) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmImportAnalyzer.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/stdlib/analyze/AnalyzeNodes.java` (+5 -1) 📝 `pkl-core/src/test/kotlin/org/pkl/core/externalreader/ExternalModuleReader.kt` (+2 -2) 📝 `pkl-core/src/test/kotlin/org/pkl/core/externalreader/ExternalReaderClient.kt` (+8 -7) 📝 `pkl-core/src/test/kotlin/org/pkl/core/externalreader/ExternalResourceReader.kt` (+2 -2) _...and 11 more files_ </details> ### 📄 Description See commit messages for details. Second commit is a pure rename refactoring. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:26:24 +01:00

adam closed this issue

2025-12-30 01:26:24 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#728