starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 15:13:38 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #773] [MERGED] Fix semver comparison logic #727

New Issue
Closed
opened 2025-12-30 01:26:24 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:24 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/773
Author: @bioball
Created: 11/2/2024
Status: ✅ Merged
Merged: 11/4/2024
Merged by: @bioball

Base: main ← Head: fix-semver

📝 Commits (1)

  • 3378f33 Fix semver comparison logic

📊 Changes

3 files changed (+48 additions, -8 deletions)

View changed files

📝 pkl-core/src/test/files/LanguageSnippetTests/input/api/semverModule.pkl (+16 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/semverModule.pcf (+20 -0)
📝 stdlib/semver.pkl (+12 -8)

📄 Description

Fix isLessThan logic between semvers

Also: adjust binary expressions to adhere to style guide

Closes https://github.com/apple/pkl/issues/772

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/773 **Author:** [@bioball](https://github.com/bioball) **Created:** 11/2/2024 **Status:** ✅ Merged **Merged:** 11/4/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix-semver` --- ### 📝 Commits (1) - [`3378f33`](https://github.com/apple/pkl/commit/3378f331c0bcfab002c5da89f5731d21353b23c2) Fix semver comparison logic ### 📊 Changes **3 files changed** (+48 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/api/semverModule.pkl` (+16 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/semverModule.pcf` (+20 -0) 📝 `stdlib/semver.pkl` (+12 -8) </details> ### 📄 Description Fix `isLessThan` logic between semvers Also: adjust binary expressions to adhere to style guide Closes https://github.com/apple/pkl/issues/772 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:24 +01:00
adam closed this issue 2025-12-30 01:26:24 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#727
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?