[PR #766] [MERGED] More external reader refinements #724

New Issue

adam · 2025-12-30T01:26:23+01:00

adam commented

2025-12-30 01:26:23 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/766
Author: @HT154
Created: 11/1/2024
Status: ✅ Merged
Merged: 11/1/2024
Merged by: @bioball

Base: main ← Head: more-external-reader-refinements

📝 Commits (3)

6821fc8 org.pkl.core.Readers -> org.pkl.core.Closeables
05edf47 Remove coupling between pkl.core.module/resource and pkl.core.messaging
3d351f1 only interface specs

📊 Changes

16 files changed (+70 additions, -55 deletions)

View changed files

📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt (+3 -3)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliImportAnalyzer.kt (+3 -3)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliTestRunner.kt (+3 -3)
📝 pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/CliJavaCodeGenerator.kt (+3 -3)
📝 pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGenerator.kt (+3 -3)
📝 pkl-core/src/main/java/org/pkl/core/Closeables.java (+2 -2)
📝 pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderProcess.java (+2 -6)
📝 pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderProcessImpl.java (+9 -9)
📝 pkl-core/src/main/java/org/pkl/core/messaging/Messages.java (+6 -3)
📝 pkl-core/src/main/java/org/pkl/core/module/ExternalModuleResolver.java (+11 -0)
📝 pkl-core/src/main/java/org/pkl/core/module/ModuleKeyFactories.java (+4 -5)
📝 pkl-core/src/main/java/org/pkl/core/module/ModuleKeys.java (+3 -4)
📝 pkl-core/src/main/java/org/pkl/core/resource/ExternalResourceResolver.java (+9 -0)
📝 pkl-core/src/main/java/org/pkl/core/resource/ResourceReaders.java (+5 -5)
📝 pkl-core/src/main/java/org/pkl/core/service/ExecutorSpiImpl.java (+2 -3)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/CliDocGenerator.kt (+2 -3)

📄 Description

Rename org.pkl.core.Readers -> org.pkl.core.Closeables
Remove coupling between pkl.core.module/resource and pkl.core.messaging

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/766 **Author:** [@HT154](https://github.com/HT154) **Created:** 11/1/2024 **Status:** ✅ Merged **Merged:** 11/1/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `more-external-reader-refinements` --- ### 📝 Commits (3) - [`6821fc8`](https://github.com/apple/pkl/commit/6821fc835c0f6bd0759b6630b237cd96eb9bb8b1) org.pkl.core.Readers -> org.pkl.core.Closeables - [`05edf47`](https://github.com/apple/pkl/commit/05edf47b91a0cb8bc8d3a0522d9306b391a6abb0) Remove coupling between pkl.core.module/resource and pkl.core.messaging - [`3d351f1`](https://github.com/apple/pkl/commit/3d351f18ba64bc76203a806b7a6c7bfa63e9725c) only interface specs ### 📊 Changes **16 files changed** (+70 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt` (+3 -3) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliImportAnalyzer.kt` (+3 -3) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliTestRunner.kt` (+3 -3) 📝 `pkl-codegen-java/src/main/kotlin/org/pkl/codegen/java/CliJavaCodeGenerator.kt` (+3 -3) 📝 `pkl-codegen-kotlin/src/main/kotlin/org/pkl/codegen/kotlin/CliKotlinCodeGenerator.kt` (+3 -3) 📝 `pkl-core/src/main/java/org/pkl/core/Closeables.java` (+2 -2) 📝 `pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderProcess.java` (+2 -6) 📝 `pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderProcessImpl.java` (+9 -9) 📝 `pkl-core/src/main/java/org/pkl/core/messaging/Messages.java` (+6 -3) 📝 `pkl-core/src/main/java/org/pkl/core/module/ExternalModuleResolver.java` (+11 -0) 📝 `pkl-core/src/main/java/org/pkl/core/module/ModuleKeyFactories.java` (+4 -5) 📝 `pkl-core/src/main/java/org/pkl/core/module/ModuleKeys.java` (+3 -4) 📝 `pkl-core/src/main/java/org/pkl/core/resource/ExternalResourceResolver.java` (+9 -0) 📝 `pkl-core/src/main/java/org/pkl/core/resource/ResourceReaders.java` (+5 -5) 📝 `pkl-core/src/main/java/org/pkl/core/service/ExecutorSpiImpl.java` (+2 -3) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/CliDocGenerator.kt` (+2 -3) </details> ### 📄 Description * Rename `org.pkl.core.Readers` -> `org.pkl.core.Closeables` * Remove coupling between `pkl.core.module`/`resource` and `pkl.core.messaging` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:26:23 +01:00

adam closed this issue

2025-12-30 01:26:23 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#724