[PR #763] [CLOSED] Vendor msgpack-java #721

New Issue

adam · 2025-12-30T01:26:22+01:00

adam commented

2025-12-30 01:26:22 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/763
Author: @bioball
Created: 11/1/2024
Status: ❌ Closed

Base: main ← Head: vendor-messagepack

📝 Commits (1)

e34af79 Vendor msgpack-java

📊 Changes

106 files changed (+10394 additions, -89 deletions)

View changed files

📝 NOTICE.txt (+15 -0)
📝 bench/gradle.lockfile (+0 -1)
📝 buildSrc/src/main/kotlin/pklFatJar.gradle.kts (+0 -1)
📝 docs/gradle.lockfile (+0 -1)
📝 gradle/libs.versions.toml (+0 -2)
📝 pkl-cli/gradle.lockfile (+8 -5)
📝 pkl-cli/pkl-cli.gradle.kts (+0 -2)
📝 pkl-cli/src/main/java/org/pkl/cli/svm/MessagePackRecomputations.java (+1 -1)
📝 pkl-codegen-java/gradle.lockfile (+8 -5)
📝 pkl-codegen-kotlin/gradle.lockfile (+8 -5)
📝 pkl-commons-cli/gradle.lockfile (+8 -5)
📝 pkl-config-java/gradle.lockfile (+8 -5)
📝 pkl-config-kotlin/gradle.lockfile (+8 -5)
📝 pkl-core/gradle.lockfile (+0 -1)
📝 pkl-core/pkl-core.gradle.kts (+0 -1)
📝 pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderMessagePackDecoder.java (+3 -3)
📝 pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderMessagePackEncoder.java (+2 -2)
📝 pkl-core/src/main/java/org/pkl/core/messaging/AbstractMessagePackDecoder.java (+5 -5)
📝 pkl-core/src/main/java/org/pkl/core/messaging/AbstractMessagePackEncoder.java (+2 -2)
📝 pkl-core/src/main/java/org/pkl/core/messaging/BaseMessagePackDecoder.java (+2 -2)

...and 80 more files

📄 Description

This adds msgpack-java's sources to pkl-core, which allows us to exclude this as a dependency.

This excludes APIs that we do not need (direct byte buffers, android support).

This follows a pattern that we have with a few other libraries (JSON, YAML).

Note: package org.pkl.core.util.msgpack is considered private, but yet is used in pkl-server. In the future, we can fix this by moving all serializing/deserializing to pkl-core.]

Note 2: this increases pkl-core's jar size from 3.3M to 3.5M.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/763 **Author:** [@bioball](https://github.com/bioball) **Created:** 11/1/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `vendor-messagepack` --- ### 📝 Commits (1) - [`e34af79`](https://github.com/apple/pkl/commit/e34af799a4a6d608a2a5dcbda7599b42fa660573) Vendor msgpack-java ### 📊 Changes **106 files changed** (+10394 additions, -89 deletions) <details> <summary>View changed files</summary> 📝 `NOTICE.txt` (+15 -0) 📝 `bench/gradle.lockfile` (+0 -1) 📝 `buildSrc/src/main/kotlin/pklFatJar.gradle.kts` (+0 -1) 📝 `docs/gradle.lockfile` (+0 -1) 📝 `gradle/libs.versions.toml` (+0 -2) 📝 `pkl-cli/gradle.lockfile` (+8 -5) 📝 `pkl-cli/pkl-cli.gradle.kts` (+0 -2) 📝 `pkl-cli/src/main/java/org/pkl/cli/svm/MessagePackRecomputations.java` (+1 -1) 📝 `pkl-codegen-java/gradle.lockfile` (+8 -5) 📝 `pkl-codegen-kotlin/gradle.lockfile` (+8 -5) 📝 `pkl-commons-cli/gradle.lockfile` (+8 -5) 📝 `pkl-config-java/gradle.lockfile` (+8 -5) 📝 `pkl-config-kotlin/gradle.lockfile` (+8 -5) 📝 `pkl-core/gradle.lockfile` (+0 -1) 📝 `pkl-core/pkl-core.gradle.kts` (+0 -1) 📝 `pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderMessagePackDecoder.java` (+3 -3) 📝 `pkl-core/src/main/java/org/pkl/core/externalreader/ExternalReaderMessagePackEncoder.java` (+2 -2) 📝 `pkl-core/src/main/java/org/pkl/core/messaging/AbstractMessagePackDecoder.java` (+5 -5) 📝 `pkl-core/src/main/java/org/pkl/core/messaging/AbstractMessagePackEncoder.java` (+2 -2) 📝 `pkl-core/src/main/java/org/pkl/core/messaging/BaseMessagePackDecoder.java` (+2 -2) _...and 80 more files_ </details> ### 📄 Description This adds msgpack-java's sources to pkl-core, which allows us to exclude this as a dependency. This excludes APIs that we do not need (direct byte buffers, android support). This follows a pattern that we have with a few other libraries (JSON, YAML). Note: package `org.pkl.core.util.msgpack` is considered private, but yet is used in `pkl-server`. In the future, we can fix this by moving all serializing/deserializing to pkl-core.] Note 2: this increases pkl-core's jar size from 3.3M to 3.5M. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:26:22 +01:00

adam closed this issue

2025-12-30 01:26:22 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#721