[PR #751] [MERGED] Correct EmbeddedExecutor to throw ExecutorException instead of PklException when project evaluation fails #716

New Issue

adam · 2025-12-30T01:26:21+01:00

adam commented

2025-12-30 01:26:21 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/751
Author: @HT154
Created: 10/29/2024
Status: ✅ Merged
Merged: 10/30/2024
Merged by: @bioball

Base: main ← Head: executor-exception-consistency

📝 Commits (4)

b860e50 Correct EmbeddedExecutor to throw ExecutorException instead of PklException when project evaluation fails
73afd16 Update ExecutorSpiImpl.java
3094558 Update pkl-executor/src/main/java/org/pkl/executor/EmbeddedExecutor.java
5507f54 Feed SPI environment variables when loading project

📊 Changes

3 files changed (+82 additions, -7 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/service/ExecutorSpiImpl.java (+15 -6)
📝 pkl-executor/src/main/java/org/pkl/executor/EmbeddedExecutor.java (+8 -0)
📝 pkl-executor/src/test/kotlin/org/pkl/executor/EmbeddedExecutorTest.kt (+59 -1)

📄 Description

There are two fixes here:

pkl-core's ExecutorSpiImpl now properly handles project evaluation errors
pkl-executor's EmbeddedExecutor now catches all RuntimeExceptions and transforms them to ExecutorException so the Executor API contract is upheld.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/751 **Author:** [@HT154](https://github.com/HT154) **Created:** 10/29/2024 **Status:** ✅ Merged **Merged:** 10/30/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `executor-exception-consistency` --- ### 📝 Commits (4) - [`b860e50`](https://github.com/apple/pkl/commit/b860e50dada821cc88ebacff677eedf3f4d181bd) Correct EmbeddedExecutor to throw ExecutorException instead of PklException when project evaluation fails - [`73afd16`](https://github.com/apple/pkl/commit/73afd161fc4b4db7a87fb79fca27ad931d913057) Update ExecutorSpiImpl.java - [`3094558`](https://github.com/apple/pkl/commit/30945586100aa565ec2a195e20515cc851d38490) Update pkl-executor/src/main/java/org/pkl/executor/EmbeddedExecutor.java - [`5507f54`](https://github.com/apple/pkl/commit/5507f5488cace452157346a3a3f7ba4ef895fc56) Feed SPI environment variables when loading project ### 📊 Changes **3 files changed** (+82 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/service/ExecutorSpiImpl.java` (+15 -6) 📝 `pkl-executor/src/main/java/org/pkl/executor/EmbeddedExecutor.java` (+8 -0) 📝 `pkl-executor/src/test/kotlin/org/pkl/executor/EmbeddedExecutorTest.kt` (+59 -1) </details> ### 📄 Description There are two fixes here: * pkl-core's `ExecutorSpiImpl` now properly handles project evaluation errors * pkl-executor's `EmbeddedExecutor` now catches all `RuntimeException`s and transforms them to `ExecutorException` so the `Executor` API contract is upheld. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:26:21 +01:00

adam closed this issue

2025-12-30 01:26:21 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#716