[PR #746] [MERGED] Add color to error formatting #711

New Issue

adam · 2025-12-30T01:26:19+01:00

adam commented

2025-12-30 01:26:19 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/746
Author: @holzensp
Created: 10/29/2024
Status: ✅ Merged
Merged: 11/1/2024
Merged by: @holzensp

Base: main ← Head: coloring

📝 Commits (8)

7164a7a Add color to error formatting
2230e53 Apply suggestions from code review
56c6574 Address reviewer comments
878327f Apply suggestions from code review
b5dadb4 Define style choices as operations on formatter (abandon semantic API)
eb82f13 Adjust margin styling
7515013 Review feedback
c69ce5f Documentation nits

📊 Changes

38 files changed (+445 additions, -114 deletions)

View changed files

📝 bench/src/jmh/java/org/pkl/core/ListSort.java (+2 -1)
📝 docs/modules/pkl-cli/partials/cli-common-options.adoc (+13 -0)
📝 docs/modules/pkl-gradle/partials/gradle-common-properties.adoc (+7 -0)
📝 docs/src/test/kotlin/DocSnippetTests.kt (+2 -1)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt (+1 -1)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliProjectPackager.kt (+1 -0)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliRepl.kt (+2 -1)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/repl/ReplMessagesTest.kt (+2 -1)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliBaseOptions.kt (+4 -0)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliCommand.kt (+1 -0)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt (+14 -0)
📝 pkl-core/src/main/java/org/pkl/core/Analyzer.java (+4 -1)
📝 pkl-core/src/main/java/org/pkl/core/EvaluatorBuilder.java (+17 -0)
📝 pkl-core/src/main/java/org/pkl/core/EvaluatorImpl.java (+7 -4)
➕ pkl-core/src/main/java/org/pkl/core/evaluatorSettings/Color.java (+30 -0)
📝 pkl-core/src/main/java/org/pkl/core/evaluatorSettings/PklEvaluatorSettings.java (+7 -1)
📝 pkl-core/src/main/java/org/pkl/core/project/Project.java (+3 -1)
📝 pkl-core/src/main/java/org/pkl/core/project/ProjectPackager.java (+6 -3)
📝 pkl-core/src/main/java/org/pkl/core/repl/ReplServer.java (+3 -2)
📝 pkl-core/src/main/java/org/pkl/core/runtime/StackTraceRenderer.java (+44 -40)

...and 18 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/746 **Author:** [@holzensp](https://github.com/holzensp) **Created:** 10/29/2024 **Status:** ✅ Merged **Merged:** 11/1/2024 **Merged by:** [@holzensp](https://github.com/holzensp) **Base:** `main` ← **Head:** `coloring` --- ### 📝 Commits (8) - [`7164a7a`](https://github.com/apple/pkl/commit/7164a7a0ca8a938f2a47dd275443d35acce4f5fd) Add color to error formatting - [`2230e53`](https://github.com/apple/pkl/commit/2230e53a24a481d05ed2aadf041b5fa88249ffee) Apply suggestions from code review - [`56c6574`](https://github.com/apple/pkl/commit/56c657473b39b4a8fd27617212921932b308fb96) Address reviewer comments - [`878327f`](https://github.com/apple/pkl/commit/878327f1da851d112ce4f76c9550748abc95c480) Apply suggestions from code review - [`b5dadb4`](https://github.com/apple/pkl/commit/b5dadb40956e6044b348f6cdb10769f9fc67733e) Define style choices as operations on formatter (abandon semantic API) - [`eb82f13`](https://github.com/apple/pkl/commit/eb82f13fc492fed7fd16ecfc3ce3f504d8bdbb09) Adjust margin styling - [`7515013`](https://github.com/apple/pkl/commit/7515013f73cdb3147d87cb2830e9449a5673f3df) Review feedback - [`c69ce5f`](https://github.com/apple/pkl/commit/c69ce5fe7220151577f5d470b230245bee154b2b) Documentation nits ### 📊 Changes **38 files changed** (+445 additions, -114 deletions) <details> <summary>View changed files</summary> 📝 `bench/src/jmh/java/org/pkl/core/ListSort.java` (+2 -1) 📝 `docs/modules/pkl-cli/partials/cli-common-options.adoc` (+13 -0) 📝 `docs/modules/pkl-gradle/partials/gradle-common-properties.adoc` (+7 -0) 📝 `docs/src/test/kotlin/DocSnippetTests.kt` (+2 -1) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliEvaluator.kt` (+1 -1) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliProjectPackager.kt` (+1 -0) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliRepl.kt` (+2 -1) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/repl/ReplMessagesTest.kt` (+2 -1) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliBaseOptions.kt` (+4 -0) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/CliCommand.kt` (+1 -0) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt` (+14 -0) 📝 `pkl-core/src/main/java/org/pkl/core/Analyzer.java` (+4 -1) 📝 `pkl-core/src/main/java/org/pkl/core/EvaluatorBuilder.java` (+17 -0) 📝 `pkl-core/src/main/java/org/pkl/core/EvaluatorImpl.java` (+7 -4) ➕ `pkl-core/src/main/java/org/pkl/core/evaluatorSettings/Color.java` (+30 -0) 📝 `pkl-core/src/main/java/org/pkl/core/evaluatorSettings/PklEvaluatorSettings.java` (+7 -1) 📝 `pkl-core/src/main/java/org/pkl/core/project/Project.java` (+3 -1) 📝 `pkl-core/src/main/java/org/pkl/core/project/ProjectPackager.java` (+6 -3) 📝 `pkl-core/src/main/java/org/pkl/core/repl/ReplServer.java` (+3 -2) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/StackTraceRenderer.java` (+44 -40) _...and 18 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:26:19 +01:00

adam closed this issue

2025-12-30 01:26:19 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#711