starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #719] [MERGED] Add version of resolved Pkl distribution to ExecutorException #692

New Issue
Closed
opened 2025-12-30 01:26:11 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:11 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/719
Author: @holzensp
Created: 10/21/2024
Status: ✅ Merged
Merged: 10/23/2024
Merged by: @holzensp

Base: main ← Head: executorShowingVersion

📝 Commits (2)

  • 8dd680a Add version of resolved Pkl distribution to ExecutorException
  • 92a7a20 Review comments

📊 Changes

2 files changed (+30 additions, -1 deletions)

View changed files

📝 pkl-executor/src/main/java/org/pkl/executor/EmbeddedExecutor.java (+1 -1)
📝 pkl-executor/src/main/java/org/pkl/executor/ExecutorException.java (+29 -0)

📄 Description

Only when catching an exception from evaluation can we decorate the ExecutorException with Pkl version information (all other occurrences are pre-resolution failures or failure-to-resolve). That's why this PR adds an extra constructor.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/719 **Author:** [@holzensp](https://github.com/holzensp) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/23/2024 **Merged by:** [@holzensp](https://github.com/holzensp) **Base:** `main` ← **Head:** `executorShowingVersion` --- ### 📝 Commits (2) - [`8dd680a`](https://github.com/apple/pkl/commit/8dd680a9e51333e0d6568b60e2079938b0b4202f) Add version of resolved Pkl distribution to `ExecutorException` - [`92a7a20`](https://github.com/apple/pkl/commit/92a7a201608abf8ef1779e2bcc6ee8e4e2556aa9) Review comments ### 📊 Changes **2 files changed** (+30 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkl-executor/src/main/java/org/pkl/executor/EmbeddedExecutor.java` (+1 -1) 📝 `pkl-executor/src/main/java/org/pkl/executor/ExecutorException.java` (+29 -0) </details> ### 📄 Description Only when catching an exception from evaluation can we decorate the `ExecutorException` with Pkl version information (all other occurrences are pre-resolution failures or failure-to-resolve). That's why this PR adds an extra constructor. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:11 +01:00
adam closed this issue 2025-12-30 01:26:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#692
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?