[PR #701] [MERGED] Replace some usages of java.lang.String.replaceAll with String.replace #682

New Issue

adam · 2025-12-30T01:26:08+01:00

adam commented

2025-12-30 01:26:08 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/701
Author: @odenix
Created: 10/16/2024
Status: ✅ Merged
Merged: 10/17/2024
Merged by: @bioball

Base: main ← Head: replace-all

📝 Commits (1)

c0b8834 Replace some usages of java.lang.String.replaceAll with String.replace

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java (+2 -2)
📝 pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java (+2 -2)

📄 Description

Both methods replace all occurrences.
The difference is that String.replaceAll interprets its first argument as a regex.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/701 **Author:** [@odenix](https://github.com/odenix) **Created:** 10/16/2024 **Status:** ✅ Merged **Merged:** 10/17/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `replace-all` --- ### 📝 Commits (1) - [`c0b8834`](https://github.com/apple/pkl/commit/c0b883458dec6fb5e7b425c2c6c8b380d35c65bd) Replace some usages of java.lang.String.replaceAll with String.replace ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/ast/builder/AstBuilder.java` (+2 -2) 📝 `pkl-core/src/main/java/org/pkl/core/packages/PackageResolvers.java` (+2 -2) </details> ### 📄 Description Both methods replace all occurrences. The difference is that String.replaceAll interprets its first argument as a regex. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:26:08 +01:00

adam closed this issue

2025-12-30 01:26:08 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#682