starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #700] Error when JSON/YAML parsing would set property default in a Dynamic #681

New Issue
Open
opened 2025-12-30 01:26:07 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:07 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/700
Author: @HT154
Created: 10/16/2024
Status: 🔄 Open

Base: main ← Head: parse-dynamic-disallow-default

📝 Commits (3)

  • da52ac5 Error when JSON/YAML parsing would set property default in a Dynamic
  • 28c6382 Improved error messages
  • 913c7d2 Apply suggestions from code review

📊 Changes

8 files changed (+91 additions, -1 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/stdlib/json/ParserNodes.java (+8 -1)
📝 pkl-core/src/main/java/org/pkl/core/stdlib/yaml/ParserNodes.java (+11 -0)
➕ pkl-core/src/main/java/org/pkl/core/util/yaml/ParseException.java (+38 -0)
📝 pkl-core/src/main/resources/org/pkl/core/errorMessages.properties (+10 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/api/jsonParser1.pkl (+8 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/api/yamlParser2.pkl (+8 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/jsonParser1.pcf (+4 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/yamlParser2.pcf (+4 -0)

📄 Description

Resolves #561

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/700 **Author:** [@HT154](https://github.com/HT154) **Created:** 10/16/2024 **Status:** 🔄 Open **Base:** `main` ← **Head:** `parse-dynamic-disallow-default` --- ### 📝 Commits (3) - [`da52ac5`](https://github.com/apple/pkl/commit/da52ac53f7eb1236a409f0c09ac44a3078a4874d) Error when JSON/YAML parsing would set property `default` in a Dynamic - [`28c6382`](https://github.com/apple/pkl/commit/28c6382828b495e8deda53f56185374ac163f0ee) Improved error messages - [`913c7d2`](https://github.com/apple/pkl/commit/913c7d2f72f0506b61d712a26552cadb9c3ca403) Apply suggestions from code review ### 📊 Changes **8 files changed** (+91 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/stdlib/json/ParserNodes.java` (+8 -1) 📝 `pkl-core/src/main/java/org/pkl/core/stdlib/yaml/ParserNodes.java` (+11 -0) ➕ `pkl-core/src/main/java/org/pkl/core/util/yaml/ParseException.java` (+38 -0) 📝 `pkl-core/src/main/resources/org/pkl/core/errorMessages.properties` (+10 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/api/jsonParser1.pkl` (+8 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/api/yamlParser2.pkl` (+8 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/jsonParser1.pcf` (+4 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/yamlParser2.pcf` (+4 -0) </details> ### 📄 Description Resolves #561 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:07 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#681
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?