[PR #688] [MERGED] Use case-insensitive comparison for module URI schemes #673

New Issue

adam · 2025-12-30T01:26:05+01:00

adam commented

2025-12-30 01:26:05 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/688
Author: @odenix
Created: 10/15/2024
Status: ✅ Merged
Merged: 10/15/2024
Merged by: @bioball

Base: main ← Head: uri-scheme-comparison

📝 Commits (1)

36f31b6 Use case-insensitive comparison for module URI schemes

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/module/ModuleKeyFactories.java (+4 -4)

📄 Description

Previously, some factories used case-sensitive comparison, for no apparent reason.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/688 **Author:** [@odenix](https://github.com/odenix) **Created:** 10/15/2024 **Status:** ✅ Merged **Merged:** 10/15/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `uri-scheme-comparison` --- ### 📝 Commits (1) - [`36f31b6`](https://github.com/apple/pkl/commit/36f31b62673e52f3dc746e36741fb2e6fb973c6a) Use case-insensitive comparison for module URI schemes ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/module/ModuleKeyFactories.java` (+4 -4) </details> ### 📄 Description Previously, some factories used case-sensitive comparison, for no apparent reason. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:26:05 +01:00

adam closed this issue

2025-12-30 01:26:05 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#673