starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

Use java.net.http.HttpClient instead of legacy java.net.Http(s)URLConnection #67

New Issue
Closed
opened 2025-12-30 01:20:21 +01:00 by adam · 1 comment
adam commented 2025-12-30 01:20:21 +01:00
Owner
Copy Link

Originally created by @odenix on GitHub (Feb 14, 2024).

Moving to java.net.http.HttpClient brings many benefits, including:

  • HTTP/2 support
  • optional async mode
  • no need to set a system-wide default SSLSocketFactory

Instead of directly interfacing with java.net.http.HttpClient, I'd recommend to introduce a lightweight org.pkl.core.http.HttpClient facade. This keeps some flexibility and allows to enforce things like setting User-Agent.

If this sounds good, I'll work on a draft PR.

Originally created by @odenix on GitHub (Feb 14, 2024). Moving to `java.net.http.HttpClient` brings many benefits, including: * HTTP/2 support * optional async mode * no need to set a system-wide default `SSLSocketFactory` Instead of directly interfacing with `java.net.http.HttpClient`, I'd recommend to introduce a lightweight `org.pkl.core.http.HttpClient` facade. This keeps some flexibility and allows to enforce things like setting `User-Agent`. If this sounds good, I'll work on a draft PR.
adam closed this issue 2025-12-30 01:20:21 +01:00
adam commented 2025-12-30 01:20:22 +01:00
Author
Owner
Copy Link

@bioball commented on GitHub (Feb 14, 2024):

Hi, this sounds good! Go ahead and submit a PR for this.

@bioball commented on GitHub (Feb 14, 2024): Hi, this sounds good! Go ahead and submit a PR for this.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#67
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?