starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 23:23:37 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #679] [CLOSED] improve error messages for cyclical project dependencies during resolution #666

New Issue
Closed
opened 2025-12-30 01:26:02 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:02 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/679
Author: @stackoverflow
Created: 10/11/2024
Status: ❌ Closed

Base: main ← Head: cyclical-dependency-fix

📝 Commits (1)

  • fb16bb8 improve error messages for cyclical project dependencies during resolution

📊 Changes

5 files changed (+45 additions, -0 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/project/Project.java (+3 -0)
📝 pkl-core/src/main/resources/org/pkl/core/errorMessages.properties (+4 -0)
📝 pkl-core/src/test/kotlin/org/pkl/core/project/ProjectDependenciesResolverTest.kt (+14 -0)
➕ pkl-core/src/test/resources/org/pkl/core/project/projectCycle1/PklProject (+12 -0)
➕ pkl-core/src/test/resources/org/pkl/core/project/projectCycle2/PklProject (+12 -0)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/679 **Author:** [@stackoverflow](https://github.com/stackoverflow) **Created:** 10/11/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `cyclical-dependency-fix` --- ### 📝 Commits (1) - [`fb16bb8`](https://github.com/apple/pkl/commit/fb16bb831e9300f0d3c85f8be9ba872d65f41f67) improve error messages for cyclical project dependencies during resolution ### 📊 Changes **5 files changed** (+45 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/project/Project.java` (+3 -0) 📝 `pkl-core/src/main/resources/org/pkl/core/errorMessages.properties` (+4 -0) 📝 `pkl-core/src/test/kotlin/org/pkl/core/project/ProjectDependenciesResolverTest.kt` (+14 -0) ➕ `pkl-core/src/test/resources/org/pkl/core/project/projectCycle1/PklProject` (+12 -0) ➕ `pkl-core/src/test/resources/org/pkl/core/project/projectCycle2/PklProject` (+12 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:02 +01:00
adam closed this issue 2025-12-30 01:26:02 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#666
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?