starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 15:13:38 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #664] [MERGED] Add PklProject.deps.json file with newline for POSIX compliance #659

New Issue
Closed
opened 2025-12-30 01:26:00 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:26:00 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/664
Author: @holzensp
Created: 10/1/2024
Status: ✅ Merged
Merged: 10/1/2024
Merged by: @holzensp

Base: main ← Head: newlineOnResolve

📝 Commits (2)

  • b414557 Add Project.deps.json file with newline for POSIX compliance
  • 9c817bc Fix test cases

📊 Changes

4 files changed (+4 additions, -1 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/project/ProjectDeps.java (+1 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/projects/project6/PklProject.deps.json (+1 -1)
📝 pkl-core/src/test/kotlin/org/pkl/core/project/ProjectDependenciesResolverTest.kt (+1 -0)
📝 pkl-core/src/test/kotlin/org/pkl/core/project/ProjectDepsTest.kt (+1 -0)

📄 Description

Currently, PklProject.deps.json files generated by pkl project resolve do not end with a newline. POSIX requires that it does. Adding it by default avoids churn in repositories with checks / auto-corrections.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/664 **Author:** [@holzensp](https://github.com/holzensp) **Created:** 10/1/2024 **Status:** ✅ Merged **Merged:** 10/1/2024 **Merged by:** [@holzensp](https://github.com/holzensp) **Base:** `main` ← **Head:** `newlineOnResolve` --- ### 📝 Commits (2) - [`b414557`](https://github.com/apple/pkl/commit/b414557bbe6aae0dc84dbfa91a9f2183dc2859b6) Add Project.deps.json file with newline for POSIX compliance - [`9c817bc`](https://github.com/apple/pkl/commit/9c817bc24e7927411bbaa9d68bd269690dfba7cc) Fix test cases ### 📊 Changes **4 files changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/project/ProjectDeps.java` (+1 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/projects/project6/PklProject.deps.json` (+1 -1) 📝 `pkl-core/src/test/kotlin/org/pkl/core/project/ProjectDependenciesResolverTest.kt` (+1 -0) 📝 `pkl-core/src/test/kotlin/org/pkl/core/project/ProjectDepsTest.kt` (+1 -0) </details> ### 📄 Description Currently, `PklProject.deps.json` files generated by `pkl project resolve` do not end with a newline. POSIX requires that it does. Adding it by default avoids churn in repositories with checks / auto-corrections. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:26:00 +01:00
adam closed this issue 2025-12-30 01:26:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#659
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?