starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #640] [CLOSED] Refactor message-passing logic into pkl-core #655

New Issue
Closed
opened 2025-12-30 01:25:58 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:58 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/640
Author: @HT154
Created: 9/9/2024
Status: ❌ Closed

Base: main ← Head: refactor-messaging-into-core

📝 Commits (2)

  • 1b701e8 Refactor message-passing logic into pkl-core
  • 2ea97a1 Split server-specific messages/encoding/decoding back into pkl-server

📊 Changes

49 files changed (+2446 additions, -1609 deletions)

View changed files

📝 bench/gradle.lockfile (+1 -0)
📝 docs/gradle.lockfile (+1 -0)
📝 pkl-cli/gradle.lockfile (+1 -1)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliServer.kt (+2 -3)
📝 pkl-codegen-java/gradle.lockfile (+9 -4)
📝 pkl-codegen-kotlin/gradle.lockfile (+9 -4)
📝 pkl-commons-cli/gradle.lockfile (+9 -4)
📝 pkl-config-java/gradle.lockfile (+9 -4)
📝 pkl-config-kotlin/gradle.lockfile (+9 -4)
📝 pkl-core/gradle.lockfile (+1 -0)
📝 pkl-core/pkl-core.gradle.kts (+1 -0)
➕ pkl-core/src/main/java/org/pkl/core/messaging/AbstractMessagePackDecoder.java (+191 -0)
➕ pkl-core/src/main/java/org/pkl/core/messaging/AbstractMessagePackEncoder.java (+180 -0)
➕ pkl-core/src/main/java/org/pkl/core/messaging/BaseMessagePackDecoder.java (+145 -0)
➕ pkl-core/src/main/java/org/pkl/core/messaging/BaseMessagePackEncoder.java (+136 -0)
📝 pkl-core/src/main/java/org/pkl/core/messaging/DecodeException.java (+8 -8)
➕ pkl-core/src/main/java/org/pkl/core/messaging/Message.java (+145 -0)
📝 pkl-core/src/main/java/org/pkl/core/messaging/MessageDecoder.java (+7 -3)
📝 pkl-core/src/main/java/org/pkl/core/messaging/MessageEncoder.java (+5 -3)
➕ pkl-core/src/main/java/org/pkl/core/messaging/MessageTransport.java (+43 -0)

...and 29 more files

📄 Description

This is preparatory work for SPICE-0009. It is being contributed in a separate pull request to ease review.

The Message, Message(En|De)coder, and MessageTransport types have been ported to Java and moved to a new org.pkl.core.messaging package.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/640 **Author:** [@HT154](https://github.com/HT154) **Created:** 9/9/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `refactor-messaging-into-core` --- ### 📝 Commits (2) - [`1b701e8`](https://github.com/apple/pkl/commit/1b701e85086a02f5acf876c4498f7af2952308ba) Refactor message-passing logic into pkl-core - [`2ea97a1`](https://github.com/apple/pkl/commit/2ea97a1290db426294eac86fd15a61abcd4867c7) Split server-specific messages/encoding/decoding back into pkl-server ### 📊 Changes **49 files changed** (+2446 additions, -1609 deletions) <details> <summary>View changed files</summary> 📝 `bench/gradle.lockfile` (+1 -0) 📝 `docs/gradle.lockfile` (+1 -0) 📝 `pkl-cli/gradle.lockfile` (+1 -1) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliServer.kt` (+2 -3) 📝 `pkl-codegen-java/gradle.lockfile` (+9 -4) 📝 `pkl-codegen-kotlin/gradle.lockfile` (+9 -4) 📝 `pkl-commons-cli/gradle.lockfile` (+9 -4) 📝 `pkl-config-java/gradle.lockfile` (+9 -4) 📝 `pkl-config-kotlin/gradle.lockfile` (+9 -4) 📝 `pkl-core/gradle.lockfile` (+1 -0) 📝 `pkl-core/pkl-core.gradle.kts` (+1 -0) ➕ `pkl-core/src/main/java/org/pkl/core/messaging/AbstractMessagePackDecoder.java` (+191 -0) ➕ `pkl-core/src/main/java/org/pkl/core/messaging/AbstractMessagePackEncoder.java` (+180 -0) ➕ `pkl-core/src/main/java/org/pkl/core/messaging/BaseMessagePackDecoder.java` (+145 -0) ➕ `pkl-core/src/main/java/org/pkl/core/messaging/BaseMessagePackEncoder.java` (+136 -0) 📝 `pkl-core/src/main/java/org/pkl/core/messaging/DecodeException.java` (+8 -8) ➕ `pkl-core/src/main/java/org/pkl/core/messaging/Message.java` (+145 -0) 📝 `pkl-core/src/main/java/org/pkl/core/messaging/MessageDecoder.java` (+7 -3) 📝 `pkl-core/src/main/java/org/pkl/core/messaging/MessageEncoder.java` (+5 -3) ➕ `pkl-core/src/main/java/org/pkl/core/messaging/MessageTransport.java` (+43 -0) _...and 29 more files_ </details> ### 📄 Description This is preparatory work for [SPICE-0009](https://github.com/apple/pkl-evolution/pull/10). It is being contributed in a separate pull request to ease review. The Message, Message(En|De)coder, and MessageTransport types have been ported to Java and moved to a new `org.pkl.core.messaging` package. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:58 +01:00
adam closed this issue 2025-12-30 01:25:58 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#655
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?