[PR #642] [MERGED] Fix bug when reading local package assets #652

New Issue

2025-12-30T01:25:58+01:00

adam commented

2025-12-30 01:25:58 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/642
Author: @bioball
Created: 9/9/2024
Status: ✅ Merged
Merged: 9/10/2024
Merged by: @bioball

Base: main ← Head: fix-local-pkg-read

📝 Commits (1)

961d97d Fix bug when reading local package assets

📊 Changes

4 files changed (+113 additions, -24 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/resource/ResourceReaders.java (+10 -1)
📝 pkl-core/src/main/java/org/pkl/core/runtime/ResourceManager.java (+26 -23)
➕ pkl-core/src/test/files/LanguageSnippetTests/input/projects/project1/localProjectRead.pkl (+2 -0)
➕ pkl-core/src/test/files/LanguageSnippetTests/output/projects/project1/localProjectRead.pcf (+75 -0)

📄 Description

Closes https://github.com/apple/pkl/issues/641

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/642 **Author:** [@bioball](https://github.com/bioball) **Created:** 9/9/2024 **Status:** ✅ Merged **Merged:** 9/10/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix-local-pkg-read` --- ### 📝 Commits (1) - [`961d97d`](https://github.com/apple/pkl/commit/961d97dd99b55947bc3c7b2f9896f28c05cce3f2) Fix bug when reading local package assets ### 📊 Changes **4 files changed** (+113 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/resource/ResourceReaders.java` (+10 -1) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/ResourceManager.java` (+26 -23) ➕ `pkl-core/src/test/files/LanguageSnippetTests/input/projects/project1/localProjectRead.pkl` (+2 -0) ➕ `pkl-core/src/test/files/LanguageSnippetTests/output/projects/project1/localProjectRead.pcf` (+75 -0) </details> ### 📄 Description Closes https://github.com/apple/pkl/issues/641 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:25:58 +01:00

adam closed this issue

2025-12-30 01:25:58 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#652