starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-09-03 08:27:25 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #627] [CLOSED] Might be null #648

New Issue
Closed
opened 2025-12-30 01:25:56 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:56 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/627
Author: @manuelsblanco
Created: 8/16/2024
Status: ❌ Closed

Base: main ← Head: might-be-null

📝 Commits (2)

  • 3bd3701 Refactor Fibonacci class to improve performance and readability
  • 8292b9f Refactor VmMap class to improve immutability handling

📊 Changes

2 files changed (+24 additions, -5 deletions)

View changed files

📝 bench/src/jmh/java/org/pkl/core/Fibonacci.java (+19 -1)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmMap.java (+5 -4)

📄 Description

This PR refactors the VmMap class to enhance immutability handling and improve overall performance.

Key changes include:

  • Refactored the VmMap class to ensure consistent use of TruffleBoundary annotations.
  • Improved the Builder class for more efficient map construction.
  • Added null checks and robustness improvements for handling empty collections.
  • Optimized methods related to map and key order immutability.
  • These changes aim to increase the stability and reliability of the VM runtime. Please review the updates, and let me know if any adjustments are needed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/627 **Author:** [@manuelsblanco](https://github.com/manuelsblanco) **Created:** 8/16/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `might-be-null` --- ### 📝 Commits (2) - [`3bd3701`](https://github.com/apple/pkl/commit/3bd3701e617fa734a0731df58f68b1fbe08370da) Refactor Fibonacci class to improve performance and readability - [`8292b9f`](https://github.com/apple/pkl/commit/8292b9fc5a7ff906fbbfae479ef38ed6fdaa6863) Refactor VmMap class to improve immutability handling ### 📊 Changes **2 files changed** (+24 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `bench/src/jmh/java/org/pkl/core/Fibonacci.java` (+19 -1) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmMap.java` (+5 -4) </details> ### 📄 Description **This PR refactors the VmMap class to enhance immutability handling and improve overall performance.** **Key changes include:** - Refactored the VmMap class to ensure consistent use of TruffleBoundary annotations. - Improved the Builder class for more efficient map construction. - Added null checks and robustness improvements for handling empty collections. - Optimized methods related to map and key order immutability. - These changes aim to increase the stability and reliability of the VM runtime. Please review the updates, and let me know if any adjustments are needed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:56 +01:00
adam closed this issue 2025-12-30 01:25:56 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#648