starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-09-01 16:37:19 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

"Source code" link in pkl packages website broken #64

New Issue
Open
opened 2025-12-30 01:20:19 +01:00 by adam · 2 comments
adam commented 2025-12-30 01:20:19 +01:00
Owner
Copy Link
Copy Source

Originally created by @morganhein on GitHub (Feb 14, 2024).

The "source code" link on the pkl packages website is broken.
For example, here:

https://pkl-lang.org/package-docs/pkg.pkl-lang.org/pkl-go/pkl.golang/current/GeneratorSettings/index.html

The "source code" links to: https://pkl-lang.org/package-docs/pkg.pkl-lang.org/pkl-go/pkl.golang/current/GeneratorSettings/https%3A//github.com/apple/pkl-go/tree/v0.5.3/codegen/src/GeneratorSettings.pkl

Which does not work.

Originally created by @morganhein on GitHub (Feb 14, 2024). The "source code" link on the pkl packages website is broken. For example, here: https://pkl-lang.org/package-docs/pkg.pkl-lang.org/pkl-go/pkl.golang/current/GeneratorSettings/index.html The "source code" links to: https://pkl-lang.org/package-docs/pkg.pkl-lang.org/pkl-go/pkl.golang/current/GeneratorSettings/https%3A//github.com/apple/pkl-go/tree/v0.5.3/codegen/src/GeneratorSettings.pkl Which does not work.
adam commented 2025-12-30 01:20:20 +01:00
Author
Owner
Copy Link
Copy Source

@bioball commented on GitHub (Feb 14, 2024):

Thanks!

@bioball commented on GitHub (Feb 14, 2024): Thanks!
adam commented 2025-12-30 01:20:20 +01:00
Author
Owner
Copy Link
Copy Source

@sparecycles commented on GitHub (Mar 1, 2024):

Looks like a regression in the documentation generator (as if someone changed a proper URL resolve to string concatenation... 😬): if you select older versions 0.5.1 or 0.5.0, (but not 0.5.2 or 0.5.3) then the link works

image

(and then you can fixup the URL to version 0.5.3, of course, or notice that the end of the URL https%3A//github.com/apple/pkl-go/tree/v0.5.3/codegen/src/GeneratorSettings.pkl in the broken link can be URL-decoded to the same).

I'm here because I was curious about AppEnvCluster which is showing the same problem.

@sparecycles commented on GitHub (Mar 1, 2024): Looks like a regression in the documentation generator (as if someone changed a proper URL resolve to string concatenation... 😬): if you select older versions 0.5.1 or 0.5.0, (but not 0.5.2 or 0.5.3) then the [link works](https://github.com/apple/pkl-go/tree/v0.5.1/codegen/src/GeneratorSettings.pkl) <img width="338" alt="image" src="https://github.com/apple/pkl/assets/719818/8b17de06-e48d-4f3d-bfc2-95e818de3a3e"> (and then you can fixup the URL to version 0.5.3, of course, or notice that the end of the URL `https%3A//github.com/apple/pkl-go/tree/v0.5.3/codegen/src/GeneratorSettings.pkl` in the broken link can be URL-decoded to the same). --- I'm here because I was curious about [AppEnvCluster](https://pkl-lang.org/package-docs/pkg.pkl-lang.org/pkl-pantry/k8s.contrib.appEnvCluster/1.0.1/AppEnvCluster/index.html) which is showing the same problem.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#64