[PR #610] [MERGED] Fix: make Gradle tests compatible with Gradle 8.1 #637

New Issue

adam · 2025-12-30T01:25:52+01:00

adam commented

2025-12-30 01:25:52 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/610
Author: @bioball
Created: 8/6/2024
Status: ✅ Merged
Merged: 8/6/2024
Merged by: @bioball

Base: main ← Head: fix-gradle-tests

📝 Commits (1)

794c89f Fix: make Gradle tests compatible with Gradle 8.1

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 pkl-gradle/src/test/kotlin/org/pkl/gradle/EvaluatorsTest.kt (+3 -3)

📄 Description

The tests were using simple Kotlin DSL assignments, a feature only available in Gradle 8.2 and onwards. Thus, they were breaking our tests on Gradle 8.1 (the minimum Gradle version for the pkl-gradle plugin).

Tested locally:

gw :pkl-gradle:compatibilityTestReleases
Type-safe project accessors is an incubating feature.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.7/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 8m 24s
95 actionable tasks: 24 executed, 71 up-to-date

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/610 **Author:** [@bioball](https://github.com/bioball) **Created:** 8/6/2024 **Status:** ✅ Merged **Merged:** 8/6/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `fix-gradle-tests` --- ### 📝 Commits (1) - [`794c89f`](https://github.com/apple/pkl/commit/794c89f86d71f7351d9fe22ac77b02787e9cb70c) Fix: make Gradle tests compatible with Gradle 8.1 ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `pkl-gradle/src/test/kotlin/org/pkl/gradle/EvaluatorsTest.kt` (+3 -3) </details> ### 📄 Description The tests were using [simple Kotlin DSL assignments](https://blog.gradle.org/simpler-kotlin-dsl-property-assignment), a feature only available in Gradle 8.2 and onwards. Thus, they were breaking our tests on Gradle 8.1 (the minimum Gradle version for the pkl-gradle plugin). Tested locally: ``` gw :pkl-gradle:compatibilityTestReleases Type-safe project accessors is an incubating feature. Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0. You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins. For more on this, please refer to https://docs.gradle.org/8.7/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation. BUILD SUCCESSFUL in 8m 24s 95 actionable tasks: 24 executed, 71 up-to-date ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:25:52 +01:00

adam closed this issue

2025-12-30 01:25:52 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#637