starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 15:13:38 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #607] [MERGED] Fix: thrown error globbed import/read is amended #635

New Issue
Closed
opened 2025-12-30 01:25:51 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:25:51 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/607
Author: @bioball
Created: 8/1/2024
Status: ✅ Merged
Merged: 8/5/2024
Merged by: @bioball

Base: main ← Head: import-glob-fix

📝 Commits (1)

  • 2b45c21 Fix: read extra storage from owner instead of receiver

📊 Changes

6 files changed (+59 additions, -2 deletions)

View changed files

📝 pkl-core/src/main/java/org/pkl/core/ast/expression/unary/ImportGlobMemberBodyNode.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/ast/expression/unary/ReadGlobMemberBodyNode.java (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/basic/importGlob.pkl (+10 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/basic/readGlob.pkl (+8 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/basic/importGlob.pcf (+15 -0)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/basic/readGlob.pcf (+24 -0)

📄 Description

This fixes an issue where a PklBugException is thrown when a globbed read/import is amended.

Closes https://github.com/apple/pkl/issues/606

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/607 **Author:** [@bioball](https://github.com/bioball) **Created:** 8/1/2024 **Status:** ✅ Merged **Merged:** 8/5/2024 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `import-glob-fix` --- ### 📝 Commits (1) - [`2b45c21`](https://github.com/apple/pkl/commit/2b45c21103e8dc3651e6466234f4ada8dee89801) Fix: read extra storage from owner instead of receiver ### 📊 Changes **6 files changed** (+59 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/unary/ImportGlobMemberBodyNode.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/unary/ReadGlobMemberBodyNode.java` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/basic/importGlob.pkl` (+10 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/basic/readGlob.pkl` (+8 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/basic/importGlob.pcf` (+15 -0) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/basic/readGlob.pcf` (+24 -0) </details> ### 📄 Description This fixes an issue where a PklBugException is thrown when a globbed read/import is amended. Closes https://github.com/apple/pkl/issues/606 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:25:51 +01:00
adam closed this issue 2025-12-30 01:25:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#635
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?